feat: add transaction status checks to examples #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bguiz
reviewed
Jan 2, 2025
| @@ -99,7 +91,7 @@ async function scriptHtsFungibleToken() { | |||
|
|
|||
| // NOTE: Verify token using Mirror Node API | |||
| await logger.logSection('Get token data from the Hedera Mirror Node'); | |||
| const tokenVerifyMirrorNodeApiUrl = `https://testnet.mirrornode.hedera.com/api/v1/tokens/${tokenId.toString()}`; | |||
| const tokenVerifyMirrorNodeApiUrl = `https://testnet.mirrornode.hedera.com/api/v1/tokens/${tokenCreateTxReceipt.tokenId.toString()}`; | |||
There was a problem hiding this comment.
Better to move tokenId out of its current if block, and use that here instead.
| .setTokenType(TokenType.FungibleCommon) | ||
| // Configure token options: name, symbol, decimals, initial supply |
There was a problem hiding this comment.
is there a reason for removing these comments?
they were added/ requested by @SimiHunjan
There was a problem hiding this comment.
if comments were removed, it wasnt intentional. the only part of the code I meant to update were the lines adding the transaction status checks
There was a problem hiding this comment.
ok in that case pls reinstate them
Co-authored-by: Brendan Graetz <bguiz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR enhances the examples with transaction status checks, clear success/failure logging, and error handling