Fixes shrinking for shuffleCase #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Thanks! 👍 |
This was referenced Sep 4, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for hedgehogqa/fsharp-hedgehog#157 that fixes the specific issue in hedgehogqa/fsharp-hedgehog#192, which is that shrinking for
shuffleCasedoesn't work correctly.As with PR #51, the fix is to obtain all of the generators first, then swap
ListandGen(viasequencethis time), then mutate insideGen.map.Also as with PR #51, there is a test that shows this is an improvement.
I am also looking at the mutation in
shuffle, but I haven't been able write a test for that case yet, so this PR is just forshuffleCase.