Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Housekeeping #302

Merged
1 commit merged into from
Feb 3, 2021
Merged

Housekeeping #302

1 commit merged into from
Feb 3, 2021

Conversation

moodmosaic
Copy link
Member

Some housekeeping I did while going through the new Fable test-suite. Feel free to discuss and/or reject any or or all of those:

  • remove redundant space
  • remove unused open directives
  • testCaseNoFable renamed to fableIgnore
  • where possible maximum line width at 80 characters
  • where possible use expected/actual test terminology

/cc @adam-becker @TysonMN

@moodmosaic
Copy link
Member Author

I just force-pushed the branch from 667f37d to d694831. Thanks for the feedback @adam-becker 👍

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a few more comments, but none of them are blocking.

tests/Hedgehog.Tests/GenTests.fs Outdated Show resolved Hide resolved
tests/Hedgehog.Tests/GenTests.fs Outdated Show resolved Hide resolved
tests/Hedgehog.Tests/SeedTests.fs Outdated Show resolved Hide resolved
tests/Hedgehog.Tests/GenTests.fs Outdated Show resolved Hide resolved
@moodmosaic
Copy link
Member Author

Just forced-pushed. Thanks for the review. 👍

@ghost
Copy link

ghost commented Feb 3, 2021

I'll let @TysonMN weigh in before merging.

Copy link
Member

@TysonMN TysonMN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@ghost ghost merged commit 907dccc into hedgehogqa:master Feb 3, 2021
@ghost ghost added this to the 0.10.0 milestone Feb 3, 2021
@moodmosaic moodmosaic deleted the topic/housekeeping branch February 3, 2021 21:14
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants