-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Housekeeping #302
Housekeeping #302
Conversation
667f37d
to
d694831
Compare
I just force-pushed the branch from 667f37d to d694831. Thanks for the feedback @adam-becker 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left a few more comments, but none of them are blocking.
d694831
to
56ed0ce
Compare
Just forced-pushed. Thanks for the review. 👍 |
I'll let @TysonMN weigh in before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Some housekeeping I did while going through the new Fable test-suite. Feel free to discuss and/or reject any or or all of those:
open
directivestestCaseNoFable
renamed tofableIgnore
expected
/actual
test terminology/cc @adam-becker @TysonMN