Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

made Seq module internal and moved to own file #307

Merged
2 commits merged into from
Feb 7, 2021
Merged

made Seq module internal and moved to own file #307

2 commits merged into from
Feb 7, 2021

Conversation

TysonMN
Copy link
Member

@TysonMN TysonMN commented Feb 7, 2021

Fixes #306

moodmosaic
moodmosaic approved these changes Feb 7, 2021
View reviewed changes
Copy link
Member

@moodmosaic moodmosaic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM /cc @adam-becker

@TysonMN
Copy link
Member Author

TysonMN commented Feb 7, 2021

...but not to the compiler 😩

@moodmosaic
Copy link
Member

moodmosaic commented Feb 7, 2021 •
edited
Loading

Add/remove the inline keyword, maybe?

@TysonMN
Copy link
Member Author

TysonMN commented Feb 7, 2021

I think understand now.

Shrink.towards is marked as inlined, so when that code is inlined in user code, then either Seq.consNub needs to be inlined as well or it needs to be accessible, which in this case is public scope.

@ghost ghost added this to the 0.11.0 milestone Feb 7, 2021
@ghost
Copy link

ghost commented Feb 7, 2021

LGTM 👍🏼

@ghost ghost merged commit e42a648 into hedgehogqa:master Feb 7, 2021
@TysonMN TysonMN deleted the 306_seq_module branch February 8, 2021 14:11
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moodmosaic moodmosaic moodmosaic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.

Seq module scope
2 participants
@TysonMN @moodmosaic