Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add property args structure. #312

Merged
1 commit merged into from Feb 14, 2021
Merged

Add property args structure. #312

1 commit merged into from Feb 14, 2021

Conversation

ghost
Copy link

@ghost ghost commented Feb 7, 2021

This PR adds a structure to keep all the run args in a single place. This will allow us to more easily add support for #25.

/cc @moodmosaic @TysonMN

Copy link
Member

@moodmosaic moodmosaic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good, however, perhaps we can merge once we're done with #296, unless @TysonMN has a better idea.

@ghost
Copy link
Author

ghost commented Feb 8, 2021

I think this looks good, however, perhaps we can merge once we're done with #296, unless @TysonMN has a better idea.

That works for me 👍🏼

@TysonMN
Copy link
Member

TysonMN commented Feb 8, 2021

Also looks good to me. I think we should merge now instead of waiting for #296.

@ghost ghost added this to the 0.11.0 milestone Feb 14, 2021
@ghost ghost merged commit e1f87f3 into hedgehogqa:master Feb 14, 2021
@ghost ghost deleted the run-args branch February 14, 2021 22:29
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants