Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change .NET runtime targets to current recommendations #416

Merged
merged 1 commit into from
Jul 23, 2022

Conversation

LyndonGingerich
Copy link
Contributor

Solves #411.

These two warnings remain:

  NuGet.Build.Tasks.Pack.targets(221, 5): [NU5125] The 'licenseUrl' element will be deprecated. Consider using the 'license' element instead.
  NuGet.Build.Tasks.Pack.targets(221, 5): [NU5048] The 'PackageIconUrl'/'iconUrl' element is deprecated. Consider using the 'PackageIcon'/'icon' element instead. Learn more at https://aka.ms/deprecateIconUrl

@dharmaturtle
Copy link
Member

I'm a little busy this weekend so I'm not sure when I can give this more thought, but we wanna be careful when touching Fsharp.Core:

Targeting an earlier version of FSharp.Core increases your reach because older codebases can use it without issue

https://fsharp.github.io/fsharp-compiler-docs/fsharp-core-notes.html

I think it's reasonable to upgrade to 4.3.4, and I think that still solves #411, but haven't been able to thoroughly test it.

@TysonMN TysonMN force-pushed the feature/upgrade_dotnet branch from 417ccb7 to 55402fc Compare July 23, 2022 04:51
@TysonMN TysonMN changed the title Upgraded targeted .NET SDK and FSharp.Core versions Change .NET runtime targets to current recommendations Jul 23, 2022
@TysonMN
Copy link
Member

TysonMN commented Jul 23, 2022

This build says

Passed! - Failed: 0, Passed: 153, Skipped: 0, Total: 153, Duration: 239 ms - Hedgehog.Linq.Tests.dll (net6.0)
but I only see 18 tests locally.

Why is that?

@TysonMN TysonMN merged commit 98e900e into hedgehogqa:master Jul 23, 2022
@TysonMN
Copy link
Member

TysonMN commented Jul 23, 2022

I think it's reasonable to upgrade to 4.3.4, and I think that still solves #411, but haven't been able to thoroughly test it.

4.3.4 worked, so I used that.

@TysonMN TysonMN mentioned this pull request Jul 23, 2022
@TysonMN
Copy link
Member

TysonMN commented Jul 23, 2022

I wasn't planning on getting this merged tonight, but my initial attempt to release version 0.13.0 failed. I had recently updated to the latest (fork) version of the NuGet publishing GitHub action. In hindsight, I should have not made that change until this code was merged. Of course I could have reverted that change, but who wants to go backwards in life? Not me.

@moodmosaic
Copy link
Member

This build says

Passed! - Failed: 0, Passed: 153, Skipped: 0, Total: 153, Duration: 239 ms - Hedgehog.Linq.Tests.dll (net6.0)
but I only see 18 tests locally.

Why is that?

Could it be the same tests are parameterized?

@LyndonGingerich LyndonGingerich deleted the feature/upgrade_dotnet branch July 25, 2022 13:55
@TysonMN
Copy link
Member

TysonMN commented Aug 28, 2022

Could it be the same tests are parameterized?

Yes, that it is. There are 18 tests, but one has 136 parameters, and 18 - 1 + 136 = 153.

2022-08-28_14-50-56_713_devenv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants