Note reason for transitive setup functions

#168
hedronvision · Feb 1, 2024 · 0e99003 · 0e99003
1 parent 0b821b7
commit 0e99003
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 0 deletions.
diff --git a/workspace_setup_transitive.bzl b/workspace_setup_transitive.bzl
@@ -30,6 +30,7 @@ def hedron_compile_commands_setup_transitive(module_ctx = None):
 
     # Currently nothing to do -> no-op.
     # So why is this even here? Enables future expansion (e.g to add transitive dependencies) without changing the user interface.
+    # Originally added for rules_python, which we reverted, but are keeping this interface to be used once it's fixed. See https://github.com/hedronvision/bazel-compile-commands-extractor/issues/168 for details.
     pass
 
 

diff --git a/workspace_setup_transitive_transitive.bzl b/workspace_setup_transitive_transitive.bzl
@@ -30,6 +30,7 @@ def hedron_compile_commands_setup_transitive_transitive(module_ctx = None):
 
     # Currently nothing to do -> no-op.
     # So why is this even here? Enables future expansion (e.g to add transitive dependencies) without changing the user interface.
+    # Originally added for rules_python, which we reverted, but are keeping this interface to be used once it's fixed. See https://github.com/hedronvision/bazel-compile-commands-extractor/issues/168 for details.
     pass
 
 

diff --git a/workspace_setup_transitive_transitive_transitive.bzl b/workspace_setup_transitive_transitive_transitive.bzl
@@ -30,6 +30,7 @@ def hedron_compile_commands_setup_transitive_transitive_transitive(module_ctx =
 
     # Currently nothing to do -> no-op.
     # So why is this even here? Enables future expansion (e.g to add transitive dependencies) without changing the user interface.
+    # Originally added for rules_python, which we reverted, but are keeping this interface to be used once it's fixed. See https://github.com/hedronvision/bazel-compile-commands-extractor/issues/168 for details.
     pass
-Original file line number
+Diff line change
@@ Expand Up @@
         # Currently nothing to do -> no-op.
         # So why is this even here? Enables future expansion (e.g to add transitive dependencies) without changing the user interface.
+        # Originally added for rules_python, which we reverted, but are keeping this interface to be used once it's fixed. See https://github.com/hedronvision/bazel-compile-commands-extractor/issues/168 for details.
         pass
@@ Expand Down @@