Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💻 Add Ability to Rename Class #5978

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Sidd-T
Copy link

@Sidd-T Sidd-T commented Nov 28, 2024

Fixes #5965

Added functionality to rename a class, going off the instructions in the issue comments with direct editing from change on the input element.

I edited the exisiting rename_class function to directly send a request instead of opening a modal, as per the comment in the issue, but I believe it may be good to add a confirmation modal as well, let me know

Also, I wasn't sure what to do with the rename_class in the teachers.ts file, which does not seemed to be used at all, so I left it unchanged

How to test

Follow these steps to verify this PR works as intended:

  • Log in as a teacher
  • create a class
  • in the customize class page, edit the input box, and click outside the box or press enter to confirm
  • verify the name has been changed by going back

Dev Testing
https://github.com/user-attachments/assets/422caab4-89d8-4d75-8a08-03899de1d5bb

Checklist

  • Contains one of the PR categories in the name
  • Describes changes in the format above
  • Links to an existing issue or discussion
  • Has a "How to test" section

@Felienne Felienne requested a review from jpelay November 28, 2024 06:08
@Felienne
Copy link
Member

Wow thanks for the work and the very clear PR @Sidd-T!!

We will take a look in our meeting tomorrow, if not before. Feel free to join the meeting to if you want to know the project better (see Discord for the link).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ToBeDiscussed
Development

Successfully merging this pull request may close these issues.

💻 Can't rename a class
2 participants