Fixed bug in import resolver. It was incorrectly returning implicit i…

…mports for "import X" or "import X as Y" statements.
heejaechang · Feb 18, 2020 · 25758b8 · 25758b8
1 parent e7b221e
commit 25758b8
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/server/src/analyzer/importResolver.ts b/server/src/analyzer/importResolver.ts
@@ -823,7 +823,13 @@ export class ImportResolver {
     // Potentially modifies the ImportResult by removing some or all of the
     // implicit import entries. Only the imported symbols should be included.
     private _filterImplicitImports(importResult: ImportResult, importedSymbols: string[] | undefined): ImportResult {
-        if (importedSymbols === undefined || importedSymbols.length === 0) {
+        if (importedSymbols === undefined) {
+            const newImportResult = Object.assign({}, importResult);
+            newImportResult.implicitImports = [];
+            return newImportResult;
+        }
+
+        if (importedSymbols.length === 0) {
             return importResult;
         }
 

diff --git a/server/src/analyzer/sourceFile.ts b/server/src/analyzer/sourceFile.ts
@@ -796,10 +796,8 @@ export class SourceFile {
         }
     }
 
-    private _resolveImports(importResolver: ImportResolver,
-        moduleImports: ModuleImport[],
-        execEnv: ExecutionEnvironment):
-        [ImportResult[], ImportResult?, string?, string?] {
+    private _resolveImports(importResolver: ImportResolver, moduleImports: ModuleImport[],
+        execEnv: ExecutionEnvironment): [ImportResult[], ImportResult?, string?, string?] {
 
         const imports: ImportResult[] = [];