[improve][broker] PIP-192 Moved the common broker load data feature(weightedMaxEMA) to BrokerLoadData #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: apache#16691
Motivation
We will start raising PRs to implement PIP-192, apache#16691
Modifications
This PR moved the common broker load data feature(
weightedMaxEMA
) toBrokerLoadData
.As
weightedMaxEMA
is available in theBrokerLoadData
by this change, this PRremoved
brokerAvgResourceUsageWithWeight
in LeastResourceUsageWithWeight -- we don't need to separately compute and storeweightedMaxEMA
inLeastResourceUsageWithWeight and TransferShedder
.refactored
BrokerLoadData
to precompute the load data features.updated the unit tests.
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
We will have separate PRs to update the Doc later.
Matching PR in forked repository
PR in forked repository: #20