Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][broker] PIP-192 Moved the common broker load data feature(weightedMaxEMA) to BrokerLoadData #20

Closed
wants to merge 3 commits into from

Conversation

heesung-sn
Copy link
Owner

@heesung-sn heesung-sn commented Jan 6, 2023

Master Issue: apache#16691

Motivation

We will start raising PRs to implement PIP-192, apache#16691

Modifications

This PR moved the common broker load data feature(weightedMaxEMA) to BrokerLoadData.

As weightedMaxEMA is available in the BrokerLoadData by this change, this PR

  • removed brokerAvgResourceUsageWithWeight in LeastResourceUsageWithWeight -- we don't need to separately compute and store weightedMaxEMA in LeastResourceUsageWithWeight and TransferShedder.

  • refactored BrokerLoadData to precompute the load data features.

  • updated the unit tests.

Verifying this change

  • Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

  • *Added unit tests for the new classes.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

We will have separate PRs to update the Doc later.

Matching PR in forked repository

PR in forked repository: #20

@heesung-sn heesung-sn changed the title [improve][broker] PIP-192 Moved the common broker load data feature(w… [improve][broker] PIP-192 Moved the common broker load data feature(weightedMaxEMA) to BrokerLoadData Jan 6, 2023
@heesung-sn heesung-sn force-pushed the pip-192-feature-store branch from 9528960 to 0e6da72 Compare January 9, 2023 19:19
@heesung-sn heesung-sn force-pushed the pip-192-feature-store branch from 0e6da72 to 8145f59 Compare January 9, 2023 23:16
@heesung-sn heesung-sn closed this Jan 18, 2023
@heesung-sn heesung-sn deleted the pip-192-feature-store branch April 2, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant