[improve][broker] PIP-192 Improved Auto-Unload Logic #39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: Master Issue: apache#16691, apache#18099
Motivation
Raising a PR to implement Master Issue: apache#16691, apache#18099
We want to reduce unload frequencies from flaky traffic.
Modifications
This PR
loadBalancerSheddingConditionHitCountThreshold
to further restrict shedding conditions based on the hit count.loadBalanceSheddingDelayInSeconds
value from 600 to 180, as 10 mins are too long. 3 mins can be long enough to catch the new load after unloads.loadBalancerBundleLoadReportPercentage
toloadBalancerMaxNumberOfBundlesInBundleLoadReport
to make the topk bundle count absolute instead of relative.loadBalancerNamespaceBundleSplitConditionThreshold
toloadBalancerNamespaceBundleSplitConditionHitCountThreshold
to be consistent with*ConditionHitCountThreshold
.loadBalancerMaxNumberOfBrokerTransfersPerCycle
toloadBalancerMaxNumberOfBrokerSheddingPerCycle
.msgThroughputEMA
in BrokerLoadData to smooth the broker throughput info.Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
We will have separate PRs to update the Doc later.
Matching PR in forked repository
PR in forked repository: #39