Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][broker] PIP-192 made split handler idempotent #41

Closed
wants to merge 6 commits into from

Conversation

heesung-sn
Copy link
Owner

Master Issue: apache#16691

Motivation

Raising a PR to implement: apache#16691

Modifications

This PR

  • Makes split handler idempotent .
  • Makes Leader's orphan monitor keep trying to send split msg until finished.
  • Select bundle boundaries at the SplitScheduler to have the same split boundaries for each Split handler retry.
  • Adds a condition to check if the parent's Spliting state has moved.
  • Made Admin Unload command forceful to unload any bundles in invalid states.

Verifying this change

  • Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

  • *Updated unit tests.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

We will have separate PRs to update the Doc later.

Matching PR in forked repository

PR in forked repository: #40

@heesung-sn heesung-sn force-pushed the pip-192-split-bug-child-exists branch 2 times, most recently from e3b361b to 9a6708d Compare April 1, 2023 04:46
@heesung-sn heesung-sn force-pushed the pip-192-split-bug-child-exists branch from a7000c5 to c4562ca Compare April 5, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant