Linting/npm #59
Open
Linting/npm #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…had comments) - Linting: Ignore `node_modules` (useful if examining files) - Linting: Use required `ecmaVersion` minimum of 2015 - Linting: Fix broken property in config - Maintenance: Add `.editorconfig` - npm: Add `eslint` as devDep. - npm: Add `lint` script - npm: Add recommended fields such as "keywords" - npm: Remove extra WS; remove unneeded `node_modules` portion of paths - npm: Bump mocha to 7 (requires Node 6, but `engines` already expects >= 8)
- npm: Update devDep (eslint) - Travis: Drop unnecessary quotes (not needed for full semver either)
|
Do you need this split up or what can I do? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
As per jsdoctypeparser/jsdoctypeparser#109 , we'd be interested in bringing over, if nothing else, tests from our own jsdoc type parser (once it may be harmonized to follow the same API). And if you were open to it, we may also have some TypeScript types spec'd that you may wish to be able to at least tolerate, if not distinctly handle in jsdoc proper through catharsis.
As for our main project based on jsdoctypeparser,
eslint-plugin-jsdoc, we may then be able to switch its dependency tocatharsisinstead.These are just a few high-level package fixes/changes related to linting and npm/project maintenance if you could take a look.
node_modules(useful if examining files)ecmaVersionminimum of 2015.editorconfigeslintas devDep.lintscriptnode_modulesportion of pathsAlthough I didn't remove it, I thought I could also remove the
gulpinstall in.travis.yml, as I don't see it as being used.