Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Action Create, Read and Delete #106

Merged
merged 3 commits into from
Dec 15, 2022

Conversation

mrdubr
Copy link
Contributor

@mrdubr mrdubr commented Dec 14, 2022

Added support for:

New Test cases:

$ make test TESTARGS="-v -run TestAutomationActionsAction*"
==> Testing go-pagerduty
=== RUN   TestAutomationActionsActionTypeScriptGet
2022/12/14 10:44:21 ===== PagerDuty Cache Skipping Init =====
--- PASS: TestAutomationActionsActionTypeScriptGet (0.00s)
=== RUN   TestAutomationActionsActionTypeProcessAutomationGet
2022/12/14 10:44:21 ===== PagerDuty Cache Skipping Init =====
--- PASS: TestAutomationActionsActionTypeProcessAutomationGet (0.00s)
=== RUN   TestAutomationActionsActionTypeProcessAutomationCreate
2022/12/14 10:44:21 ===== PagerDuty Cache Skipping Init =====
--- PASS: TestAutomationActionsActionTypeProcessAutomationCreate (0.00s)
=== RUN   TestAutomationActionsActionDelete
2022/12/14 10:44:21 ===== PagerDuty Cache Skipping Init =====
--- PASS: TestAutomationActionsActionDelete (0.00s)
=== RUN   TestAutomationActionsActionTypeScriptCreate
2022/12/14 10:44:21 ===== PagerDuty Cache Skipping Init =====
--- PASS: TestAutomationActionsActionTypeScriptCreate (0.00s)
PASS
ok  	github.com/heimweh/go-pagerduty/pagerduty	0.245s

@mrdubr mrdubr marked this pull request as ready for review December 14, 2022 00:08
Copy link
Collaborator

@stmcallister stmcallister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

v := new(AutomationActionsActionPayload)
o := RequestOptions{
Type: "header",
Label: "X-EARLY-ACCESS",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How long will this header be required? I'm thinking we should be putting a note in the provider docs for these resources that Early Access is required.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are expecting to remove the header requirement by the end of this week. Early next, in the worst case!

Copy link
Collaborator

@imjaroiswebdev imjaroiswebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you @mrdubr this is looking great! 🎉 💪🏽

@imjaroiswebdev imjaroiswebdev merged commit 7c3850d into heimweh:master Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants