Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ORCA-3444] Add support for Event Orchestrations #88

Merged
merged 40 commits into from
May 27, 2022
Merged

[ORCA-3444] Add support for Event Orchestrations #88

merged 40 commits into from
May 27, 2022

Conversation

alenapan
Copy link
Contributor

@alenapan alenapan commented May 25, 2022 •
edited
Loading

Changes

  • Add CRUD endpoints for the Event Orchestration resource
  • Add Read/Update endpoints for the Event Orchestration Path resources (router/unrouted/service)

alenapan and others added 30 commits May 4, 2022 10:12
@alenapan
ORCA-3459 - Event Orchestration refactoring/renaming
63a85f1
@Pari-Dhanakoti
add routes, integrations to orchestration struct
faeb134
@alenapan
Add the List endpoint
99831e6
@alenapan
fix List tests
43ee2e3
@alenapan
ORCA-3459 - Event Orchestration refactoring/renaming
d048ee5
@Pari-Dhanakoti @alenapan
add routes, integrations to orchestration struct
99f2ba3
@alenapan
Add the List endpoint
9d2a6cb
@alenapan
fix List tests
062cf02
@alexzakabluk
Merge branch 'ORCA-3459-orchestration-rename' of github.com:alenapan/…
f6c0bc3 
…go-pagerduty into ORCA-3459-orchestration-rename
@alexzakabluk
Add struct of event orchestration path
79d2b81
@alexzakabluk
Add Get/Update method to EventOrchestrationPath and add test file
cda4773
@metavida
Add instructions on how to test
6509865
@Pari-Dhanakoti
Merge branch 'ORCA-3459-orchestration-rename' of github.com:alenapan/…
6522708 
…go-pagerduty into ORCA-3459-orchestration-rename
@Pari-Dhanakoti
put back omitempty for team
de33002
@metavida
Accumulate Event Orchestration pagination info
ddea966
@alexzakabluk
Add test for service path
6ef2027
@metavida
Some renaming & re-organization
3b48ffc 
* Use the more specific EventOrchestrationPathReference instead of the generic EventOrchestrationPathObject
* Use EventOrchestrationPathRuleActions and include all actions so that we eliminate EventOrchestrationPathRuleAction and eliminate trying to do struct inheritance/injection.
@metavida
WIP: Working towards a working TestEventOrchestrationPathRouterPathGet
f078511
@metavida
A test that builds a successful response!
45d3eb1
@metavida
A working, simplified TestEventOrchestrationPathRouterPathGet
c7a77aa
@metavida
Add GetUnroutedPath and GetServicePath tests
d3f28e4 
Also make `UrlBuilder` private by renaming it `orchestrationPathUrlBuilder`
@alexzakabluk
Add Update tests for router, unrouted and service pathTypes
65239c3
@alenapan
remove commented out line
de718e6
@alenapan
Merge pull request #2 from alenapan/ORCA-3462-orchestration-path
48e4e29 
[ORCA-3462] -  Add Read/Update for Event Orchestration paths
@alenapan
Merge pull request #3 from alenapan/ORCA-3459-orchestration-rename
cce185d 
[ORCA-3459][ORCA-3462] - Event Orchestration / Event Orchestration Path support
@alenapan
ORCA-3475 - make event orchestration team id a nullable field
3873add
@alenapan
Merge pull request #4 from alenapan/ORCA-3475-event-orch-allow-nullab…
4071eac 
…le-props

[ORCA-3475] Make event orchestration team ID a nullable field
@alenapan
Remove 'omitempty' from the EventOrchestrationPathSet.Rules property
2fb8e12
@Pari-Dhanakoti
Merge pull request #5 from alenapan/remove-omitempty-from-orch-rules
9607172 
Remove 'omitempty' from the EventOrchestrationPathSet.Rules property
@Pari-Dhanakoti
do not drop empty conditions
2034471
alenapan and others added 9 commits May 12, 2022 16:33
@alenapan
Merge pull request #6 from alenapan/make-conditions-not-drop-empty
85df18a 
Do not drop empty conditions
@alexzakabluk
Removed omit empty from variables, extractions, automation actions ob…
68611a3 
…ject
@alexzakabluk
Removed omit empty from struct
e4ef5ca
@Pari-Dhanakoti
Merge pull request #7 from alenapan/remove-omitempty-orca-path
d6bd293 
Removed omit empty from variables, extractions, automation actions ob…
@alenapan
Event Orchestration pat action - Suspend - omitempty
c0d3fc3
@alenapan
Merge pull request #8 from alenapan/event-orch-path-suspend-omitempty
a03353a 
Event Orchestration pat action - Suspend - omitempty
@alenapan
make suspend nullable
73ff8b4
@alenapan
not ignore empty route_to, add extraction props
264c534
@Pari-Dhanakoti
Merge pull request #9 from alenapan/event-orch-path-suspend-omitempty
8279a7b 
[ORCA-3465] - Modify Event Orchestration Path Action Properties
@alenapan alenapan changed the title Add support for Event Orchestrations [ORCA-3444] Add support for Event Orchestrations May 25, 2022
@alenapan alenapan mentioned this pull request May 25, 2022
Merged
3 tasks
stmcallister
stmcallister approved these changes May 27, 2022
View reviewed changes
Copy link
Collaborator

@stmcallister stmcallister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Excited to get this added to the provider!! 👍 🎉 🌮

pagerduty/event_orchestration_path_test.go
"orchestration_path": {
"type": "service",
"parent": {
"id": "POOPBUG",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice name ;)

@stmcallister stmcallister merged commit 4e587aa into heimweh:master May 27, 2022
@stmcallister stmcallister mentioned this pull request May 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmcallister stmcallister stmcallister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alenapan @stmcallister @Pari-Dhanakoti @alexzakabluk @metavida