Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Facebook service to latest Facebook Graph API version v9.0 #169

Closed

Conversation

richard67
Copy link
Contributor

Current Facebook Graph API version v9.0 has been released yesterday, see https://developers.facebook.com/docs/graph-api/changelog.

There have not been any breaking changes regarding sharing counts, see https://developers.facebook.com/docs/graph-api/changelog/version9.0, so only the version number has to be increased with this PR here.

How to test: Code review should be sufficient, but if necessary, check if Facebook counts still work with this PR applied. Of course I've tested this on my website, as usual.

Reason for this PR:

As already elaborated in PR #128, Shariff backend will not get any result for an app_id if the app has been created with a newer Graph API version than the one which Shariff backend uses in the URL for getting the counts, because a Facebook app is limited to the minimum Graph API version which was current when the app has been created.

@richard67
Copy link
Contributor Author

@compeak @sehkunde This time please make a new release (patch version should be enough regarding semver) after this PR will be merged.

@richard67
Copy link
Contributor Author

Closing in favour of #173 .

@richard67 richard67 closed this May 17, 2021
@richard67 richard67 deleted the update-fb-graph-api-9.0 branch May 17, 2021 09:23
@richard67 richard67 restored the update-fb-graph-api-9.0 branch May 17, 2021 14:00
@richard67
Copy link
Contributor Author

Re-opening, reasons see #173 (comment) .

@richard67
Copy link
Contributor Author

Closing in favour of #174 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant