Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add {url} replacement to mailBody #185

Merged
merged 1 commit into from
Jul 13, 2017
Merged

Add {url} replacement to mailBody #185

merged 1 commit into from
Jul 13, 2017

Conversation

stephankellermayr
Copy link
Contributor

I am using the TYPO3-extension rx_shariff and if i set the attribute data-mail-body, it completely replaces the URL which will be inserted automatically if there is no data-mail-body-attribute.

But a mail without link does not make any sense, so i would like to replace the placeholder {url} with shariff.getURL().

Is this the right place for such modification?

@liayn
Copy link
Contributor

liayn commented Oct 6, 2016

We, as maintainer of the rx_shariff extension, would appreciate a solution directly in the shariff core. It would of course be possible to offer such a "placeholder"-solution also with our extension, but in general it makes sense to have a placeholder in the data-mail-body option if this is set to a string.

@compeak
Copy link
Collaborator

compeak commented Nov 4, 2016

@stephankellermayr: Please provide some documentation of this feature in README.md/README-de.md.

@compeak compeak self-assigned this Nov 4, 2016
@compeak compeak merged commit 7b43985 into heiseonline:master Jul 13, 2017
@compeak
Copy link
Collaborator

compeak commented Jul 13, 2017

Please provide some documentation of this feature in README.md/README-de.md.

Done.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants