Update Xing sharing link URL

[richard67]

Pull request (PR) for issue #353 .

It seems that either Xing have changed their sharing URL, or the link in Shariff was always different to what is written in Xing documentation on https://dev.xing.com/plugins/share_button/docs, section "Custom design":

We recommend using the generator to create your Share Button. However, you can use your own custom button with the following link:

https://www.xing.com/spi/shares/new?url=[URL_TO_BE_SHARED]

My favourite source for sharing links https://github.com/vinkla/shareable-links/blob/master/README.md#xing also uses https://www.xing.com/spi/shares/new?url=.

For some reason the https://www.xing.com/social_plugins/share?url= currently used by Shariff also works for me, but not for the author of issue #353 .

Of course I've tested the changes of this PR.

How to test:

Run the shariff demo site locally on a Linux host which has git and npm installed with the branch of this PR as follows:

$ mkdir shariff-test-pr354
$ cd shariff-test-pr354
$ git clone https://github.com/richard67/shariff-plus.git
$ cd shariff-plus
$ git checkout patch-1
$ git pull origin patch-1
$ npm install
$ npm run dev

Check the result in the browser, URL=http://localhost:3000/.

Check the result

Verify that the Xing sharing links in examples 2 to 4 of the demo still work (or work again if it has not worked before).

Clean up after the test

$ cd ../..
$ rm -rf ./shariff-test-pr354

[neffets]

patch-1 is working

[compeak]

Thanks.

[RalfRoemling]

Hi Richard, doesn't seem to work anymore. When opening https://www.xing.com/spi/shares/new I get an error "Ungültige bzw. nicht unterstützte URL "

[neffets]

@RalfRoemling the url is working, but You have to set the url parameter
https://www.xing.com/spi/shares/new?url=https%3A%2F%2Fgithub.com%2Fheiseonline%2Fshariff%2Fpull%2F354

Xing then adds per redirect an own parameter sc_p=...

Its working as signed-in-user as well as a not-yet-signed-in-user (then with redirect via login.xing.com)

[RalfRoemling]

Yep, thought so too, and yep not logged in user is directed to the login form. But sth isn't working.

When clicking the XING button on one of the articles on
https://www.kanzlei-breuning.de/2017/

,e.g. the first one, the opened link is
https://www.xing.com/spi/shares/new?url=https%3A%2F%2Fwww.kanzlei-breuning.de%2Faktuelles%2Funser-steuerberater-fuer-ihre-faelle-mirko-paeper%2F
which seems ok to me.

Any idea why the XING-Api doesn't like it?

[neffets]

Xing trys to load the given url to present title and body.
Maybe xing cannot work with the use HTTP2-protocol by your server.