Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WhatsApp: Support for WhatsApp Web by updating url #381

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

NoNamePro0
Copy link
Contributor

Short: Make the WhatsApp-Links compatible with WhatsApp Web

By using https://api.whatsapp.com/send?text=A Text instead of whatsapp://send?text=A Text

Pull Request #366 makes the same, but using wa.me which is just a redirect to api.whatsapp.com. So for the performance, this pull request with this link is better.

This pull request will fix #352

Overview Links

Mobile Only
  • whatsapp://send?text=A Text
Web and Mobile

Change from 'whatsapp://' to 'https://api.whatsapp.com/'
@richard67
Copy link
Contributor

Seems to be correct according to https://github.com/bradvin/social-share-urls#whatsapp.

@richard67
Copy link
Contributor

@compeak I've tested this PR with success with WhatsApp on mobile (iPhone) and also with the WhatsApp Desktop App for Windows 10, so I think it can be merged.

@pbru87
Copy link

pbru87 commented Jan 17, 2021

@NoNamePro0: I think it would be a good idea to set the "popup" parameter to "true" (popup: true,). Otherwise the WhatsApp link opens in the same tab (on desktop browsers; tested with Google Chrome), which is not the ususal Shariff behavior.

@pmb0 pmb0 merged commit 07e3074 into heiseonline:develop Sep 19, 2023
@richard67
Copy link
Contributor

@pmb0 Have you checked the comment above about the popup parameter?

@pmb0
Copy link
Member

pmb0 commented Sep 19, 2023

@pmb0 Have you checked the comment above about the popup parameter?

ca92a7a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WhatsApp doesn't open
4 participants