Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev] Focused radio button styles underlapping wrapping container #56

Closed
leymannx opened this issue Apr 24, 2019 · 10 comments
Closed

[dev] Focused radio button styles underlapping wrapping container #56

leymannx opened this issue Apr 24, 2019 · 10 comments

Comments

@leymannx
Copy link
Contributor

Following #53 (comment) I found the styles of a focused radio button looks a little bit odd as its overlapped by the wrapping container. Is this WP core interfering?

Adding screenshots for clarification:

Screenshot 2019-04-24 10 32 39
Screenshot 2019-04-24 10 33 02

@helgatheviking
Copy link
Owner

helgatheviking commented Apr 24, 2019 via email

@helgatheviking
Copy link
Owner

As far as I can tell, this is also a problem in core. Therefore, I may not make any specific changes. If they add a little margin for checkboxes it should be ok in Radio buttons too.

image

@leymannx
Copy link
Contributor Author

Ah yes, thanks a lot for confirming Kathy! I guess then we can close this issue as "works as designed" or "not our bug", I'd say.

@helgatheviking
Copy link
Owner

Agreed! Not my bug! :) Was just about to open an issue at Gutenberg, but it appears there already is one.

Let me try to get this packaged up and into the SVN repo.

@helgatheviking
Copy link
Owner

PS- thanks for all your help testing!

@leymannx
Copy link
Contributor Author

leymannx commented Apr 24, 2019

You are welcome! Was really a pleasure to help you and watch the progress. Can you please ping me one last time as soon as the update is released on wordpress.org? I think I'm going to tweet about it and need to update my review on wordpress.org.

@helgatheviking
Copy link
Owner

@leymannx did my usual fight with SVN but 2.0 is now in the repo! will definitely appreciate you updating the review.

@leymannx
Copy link
Contributor Author

Wow that was fast! I updated my review. ⭐️ ⭐️ ⭐️ ⭐️ ⭐️

@leymannx
Copy link
Contributor Author

Do you know how to update the "Tested up to:" version as well? I think it should say 5.1.1

Screenshot 2019-04-24 17 48 53

@helgatheviking
Copy link
Owner

helgatheviking commented Apr 25, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants