-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dev] Focused radio button styles underlapping wrapping container #56
Comments
I don't think I'm adding any styles. But I did see this too. Doesn't seem
to be a problem for places where they are using radio in core.. like post
status.
…On Wed, Apr 24, 2019, 5:40 PM Norman Kämper-Leymann < ***@***.***> wrote:
Following #53 (comment)
<#53 (comment)>
I found the styles of a focused radio button looks a little bit odd as its
overlapped by the wrapping container. Is this WP core interfering?
Adding screenshots for clarification:
[image: Screenshot 2019-04-24 10 32 39]
<https://user-images.githubusercontent.com/3585653/56645126-5be21880-667d-11e9-8ce5-36d078c4d342.png>
[image: Screenshot 2019-04-24 10 33 02]
<https://user-images.githubusercontent.com/3585653/56645137-600e3600-667d-11e9-8eb9-b31afb8e9c13.png>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#56>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAD3ZEMYDUMJ636ZQUZYI23PSAMIHANCNFSM4HIBUTYA>
.
|
Ah yes, thanks a lot for confirming Kathy! I guess then we can close this issue as "works as designed" or "not our bug", I'd say. |
Agreed! Not my bug! :) Was just about to open an issue at Gutenberg, but it appears there already is one. Let me try to get this packaged up and into the SVN repo. |
PS- thanks for all your help testing! |
You are welcome! Was really a pleasure to help you and watch the progress. Can you please ping me one last time as soon as the update is released on wordpress.org? I think I'm going to tweet about it and need to update my review on wordpress.org. |
@leymannx did my usual fight with SVN but 2.0 is now in the repo! will definitely appreciate you updating the review. |
Wow that was fast! I updated my review. ⭐️ ⭐️ ⭐️ ⭐️ ⭐️ |
Yes, looks like I updated that in the plugin file, but forgot to update on
the readme.txt which is where the .org page pulls it's info from.
Updated!
…On Thu, Apr 25, 2019, 12:51 AM Norman Kämper-Leymann < ***@***.***> wrote:
Do you know how to update the "Tested up to:" version as well? I think it
should say 5.1.1
[image: Screenshot 2019-04-24 17 48 53]
<https://user-images.githubusercontent.com/3585653/56673980-84880380-66b9-11e9-966a-0d842d0f2fea.png>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#56 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAD3ZENLTCUWFTXJUGH3AL3PSB6XNANCNFSM4HIBUTYA>
.
|
Following #53 (comment) I found the styles of a focused radio button looks a little bit odd as its overlapped by the wrapping container. Is this WP core interfering?
Adding screenshots for clarification:
The text was updated successfully, but these errors were encountered: