Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some old presets don't load anymore due to JSON null #619

Closed
helgoboss opened this issue Jul 3, 2022 · 1 comment
Closed

Some old presets don't load anymore due to JSON null #619

helgoboss opened this issue Jul 3, 2022 · 1 comment
Labels
bug Something isn't working realearn Related to ReaLearn

Comments

@helgoboss
Copy link
Owner

I tried a few old presets which seem to use null and somehow they don't work anymore.

We should treat a JSON null value the same like an omitted property. Solution approach: serde-rs/serde#1098 (comment)

On this occasion, it would also be a good idea to dump the JSON whenever a deserialization error occurs.
@helgoboss helgoboss added the bug Something isn't working label Jul 3, 2022
helgoboss added a commit that referenced this issue Jul 4, 2022
@helgoboss
#619 Dump session JSON if a deserialization error occurs
9714f57
@helgoboss
Copy link
Owner Author

Specifically issue-27-out-of-range.RPP was not loadable because of ParamSetting::name.

helgoboss added a commit that referenced this issue Jul 4, 2022
@helgoboss
#619 Restore backward compatibility to some old presets which use JSO…
85c9024 
…N null
@helgoboss helgoboss added the realearn Related to ReaLearn label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working realearn Related to ReaLearn
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@helgoboss