Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playtime: Hypothetical issue: Retrospective start of clip might conflict with lazy stop of old clip #967

Closed
helgoboss opened this issue Jul 23, 2024 · 1 comment
Labels
bug Something isn't working easy Would be quite easy to implement playtime Related to Playtime
Milestone

Comments

@helgoboss
Copy link
Owner

Playtime currently has some tolerance when a clip with quantized start timing is triggered a tiny bit too late ... it will then start immediately at the correct position. However, quantized stop doesn't have this tolerance: If stop is triggered too late, it will schedule the clip for stop at the next quantized position.

This combination can lead to clips being played overlapped when they actually should be played exclusively (exclusive column mode).

Find a good way to deal with this.

@helgoboss helgoboss added bug Something isn't working playtime Related to Playtime labels Jul 23, 2024
@helgoboss helgoboss changed the title Hypothetical issue: Retrospective start of clip might conflict with lazy stop of old clip Playtime: Hypothetical issue: Retrospective start of clip might conflict with lazy stop of old clip Jul 23, 2024
@helgoboss helgoboss added the easy Would be quite easy to implement label Jul 26, 2024
helgoboss added a commit that referenced this issue Aug 1, 2024
- Consequence: One needs to trigger quantized clips before the beat is reached, there's no tolerance anymore
- This circumvents the possible issue of overlapping.
- It clearly reveals timing issues related to quantized playing of clips, PDC stuff, transport sync etc.
@helgoboss
Copy link
Owner Author

helgoboss commented Aug 1, 2024

For now, we completely disable retrospective start. Let's see how this feels in practice.

  • Consequence: One needs to trigger quantized clips before the beat is reached, there's no tolerance anymore
  • This circumvents the possible issue of overlapping.
  • It clearly reveals timing issues related to quantized playing of clips, PDC stuff, transport sync etc.
  • It also helps preventing false-positive bug reports of users complaining that first notes or transients are missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working easy Would be quite easy to implement playtime Related to Playtime
Projects
Status: Done
Development

No branches or pull requests

1 participant