Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Make it run with v12 #92

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

georgringer
Copy link

No description provided.

@liayn
Copy link

liayn commented Feb 26, 2024

@helhum Maybe we can get this merged and tagged?

There are quite some extensions requiring this library. public example: sup7even/mailchimp
It would be great to get these up to v12 now.
Thanks.

@SvenJuergens
Copy link

SvenJuergens commented Apr 25, 2024

@helhum I can only agree with @liayn , it would be nice if you could find time to merge it :)

@mgrundkoetter
Copy link

@helhum pls merge

@helhum
Copy link
Owner

helhum commented May 14, 2024

@liayn @SvenJuergens @mgrundkoetter The code here is WIP in some regards. All tests are red.
I can totally understand you are wishing to have a released version of this extension compatible with TYPO3 12. I would love to have it, too. At the same time I can't responsibly merge this change to main. It does not meet my standards to have a clean history for the main branch with every commit representing a fully working and clean version. Also at the same time, I don't have on my priority list to work on this.

Working on it would mean to spend over 6h to fulfil the list,
instead of spending this time with my family or doing customer work to have something on the plate for my family.

Here is a rough todo list for this PR to be merged in main:

  • Tests must be green
  • No commented out code in version control
  • No unformatted code in version control (csfixer must be green)
  • No fully qualified namespaces in version control

Nevertheless you have many options to proceed with the situation:

  1. Migrate your code to use Topwire. It took me a couple of minutes in several projects to do so.
  2. Update this PR to Check all the boxes or create a new one based on it that checks these boxes
  3. Use this PR as patch file in your Composer project
  4. Integrate Georgs fork into your Compoer project
  5. Use the branch that I created now as version dev-v12
  6. Sponsor anyone (could be me, but does not need to be me) to work and fulfill 2.

All in all, I can again only recommend to migrate to Topwire. Topwire can do everything TypoScript Rendering can do and so much more. Migrating from TypScript Rendering to Topwire takes a fraction of the time of any other migration task you need to do to migrate your code from TYPO3 11 to 12.

Please tell me if I am missing something, or if any of the provided options might help you.

Last but not least: I will release a version of this extension compatible with TYPO3 12 at some point. If nobody picks up the tasks to help me out, I can't promise a date though.

@liayn
Copy link

liayn commented May 14, 2024

Thanks a lot for the detailed wrap up. I fully understand this.

Regarding topwire:
For 99% of our use cases topwire simply ships too much, which we don't need.
Our most important use case is to generate a URL to some action, which is then used by some JS to retrieve data.
<div data-action="{h:uri.ajaxAction(action: 'validateVatIdAjax')}"> is a typical example. (I did not check, whether this can be achieved meanwhile with pure Core functionality, though.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants