fix according to feedback

.github/workflows/cargo-doc.yaml

@@ -28,7 +28,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
-          toolchain: nightly-2024-04-21
+          toolchain: stable
       - name: Install Protoc
         uses: heliaxdev/setup-protoc@v2
         with:

clippy.toml

@@ -1 +1 @@
-msrv = "1.76.0"
+msrv = "1.79.0"

crates/chain-registry/Cargo.toml

@@ -6,7 +6,7 @@ license      = "Apache-2.0"
 keywords     = ["cosmos", "ibc", "relayer", "chain", "registry"]
 repository   = "https://github.com/informalsystems/hermes"
 authors      = ["Informal Systems <hello@informal.systems>"]
-rust-version = "1.76.0"
+rust-version = "1.79.0"
 description  = """
     Service to fetch data from the chain-registry
 """

crates/relayer-cli/Cargo.toml

@@ -8,7 +8,7 @@ keywords   = ["blockchain", "consensus", "cosmos", "ibc", "tendermint"]
 homepage   = "https://hermes.informal.systems/"
 repository = "https://github.com/informalsystems/hermes"
 authors    = ["Informal Systems <hello@informal.systems>"]
-rust-version = "1.76.0"
+rust-version = "1.79.0"
 description  = """
   Hermes is an IBC Relayer written in Rust
 """

crates/relayer-cli/src/commands/keys/add.rs

@@ -236,11 +236,11 @@ pub fn add_key(
             let mut wallet = CliWalletUtils::new(path.to_path_buf());
             wallet
                 .load()
-                .map_err(|_| eyre!("error loading Namada wallet"))?;
+                .map_err(|e| eyre!("error loading Namada wallet: {e}"))?;
 
             let secret_key = wallet
                 .find_secret_key(key_name, None)
-                .map_err(|_| eyre!("error loading the key from Namada wallet"))?;
+                .map_err(|e| eyre!("error loading the key from Namada wallet: {e}"))?;
             let address = wallet
                 .find_address(key_name)
                 .ok_or_else(|| eyre!("error loading the address from Namada wallet"))?;

crates/relayer-rest/Cargo.toml

@@ -8,7 +8,7 @@ readme       = "README.md"
 keywords     = ["ibc", "rest", "api", "cosmos", "tendermint"]
 homepage     = "https://hermes.informal.systems/"
 repository   = "https://github.com/informalsystems/hermes"
-rust-version = "1.76.0"
+rust-version = "1.79.0"
 description  = """
   Rust implementation of a RESTful API server for Hermes
 """

crates/relayer-types/Cargo.toml

@@ -7,7 +7,7 @@ readme       = "README.md"
 keywords     = ["blockchain", "consensus", "cosmos", "ibc", "tendermint"]
 repository   = "https://github.com/informalsystems/hermes"
 authors      = ["Informal Systems <hello@informal.systems>"]
-rust-version = "1.76.0"
+rust-version = "1.79.0"
 description  = """
     Implementation of the Inter-Blockchain Communication Protocol (IBC).
     This crate comprises the main data structures and on-chain logic.

crates/relayer/Cargo.toml

@@ -7,7 +7,7 @@ readme       = "README.md"
 keywords     = ["blockchain", "consensus", "cosmos", "ibc", "tendermint"]
 repository   = "https://github.com/informalsystems/hermes"
 authors      = ["Informal Systems <hello@informal.systems>"]
-rust-version = "1.76.0"
+rust-version = "1.79.0"
 description  = """
     Implementation of an IBC Relayer in Rust, as a library
 """

crates/telemetry/Cargo.toml

@@ -7,7 +7,7 @@ readme       = "README.md"
 keywords     = ["cosmos", "ibc", "relayer", "telemetry"]
 repository   = "https://github.com/informalsystems/hermes"
 authors      = ["Informal Systems <hello@informal.systems>"]
-rust-version = "1.76.0"
+rust-version = "1.79.0"
 description  = """
     Telemetry service for the Hermes IBC relayer
 """

tools/integration-test/Cargo.toml

@@ -2,7 +2,7 @@
 name         = "ibc-integration-test"
 version      = "0.29.4"
 edition      = "2021"
-rust-version = "1.76.0"
+rust-version = "1.79.0"
 license      = "Apache-2.0"
 readme       = "README.md"
 keywords     = ["blockchain", "consensus", "cosmos", "ibc", "tendermint"]

tools/test-framework/src/bootstrap/namada.rs

@@ -174,7 +174,6 @@ pub fn bootstrap_namada_node(
 
     let args: Vec<&str> = base_args.to_vec();
 
-    //let mut child = Command::new(&chain_driver.command_path)
     let mut child = Command::new("namadan")
         .args(&args)
         .stdin(Stdio::null())

tools/test-framework/src/chain/cli/query.rs

@@ -113,7 +113,6 @@ pub fn query_namada_balance(
 ) -> Result<Amount, Error> {
     let output = simple_exec(
         chain_id,
-        //command_path,
         "namadac",
         &[
             "--base-dir",

tools/test-framework/src/chain/config/namada.rs

@@ -28,7 +28,7 @@ pub fn set_p2p_port(config: &mut Value, port: u16) -> Result<(), Error> {
         .get_mut("cometbft")
         .ok_or_else(|| eyre!("expect cometbft section"))?
         .get_mut("p2p")
-        .ok_or_else(|| eyre!("expect cometbft rpc"))?
+        .ok_or_else(|| eyre!("expect cometbft p2p"))?
         .as_table_mut()
         .ok_or_else(|| eyre!("expect object"))?
         .insert(
@@ -39,7 +39,7 @@ pub fn set_p2p_port(config: &mut Value, port: u16) -> Result<(), Error> {
     Ok(())
 }
 
-/// Set the `p2p` field in the full node config.
+/// Set the `proxy_app` field in the full node config.
 pub fn set_proxy_app_port(config: &mut Value, port: u16) -> Result<(), Error> {
     config
         .get_mut("ledger")
@@ -56,7 +56,7 @@ pub fn set_proxy_app_port(config: &mut Value, port: u16) -> Result<(), Error> {
     Ok(())
 }
 
-/// Set the `p2p` field in the full node config.
+/// Set the `block_cache_bytes` field in the full node config.
 pub fn set_block_cache_bytes(config: &mut Value, block_cache_bytes: i64) -> Result<(), Error> {
     config
         .get_mut("ledger")

tools/test-framework/src/relayer/transfer.rs

@@ -125,7 +125,6 @@ pub async fn ibc_token_transfer<SrcChain, DstChain>(
         })
         .ok_or_else(|| eyre!("failed to find send packet event"))?;
 
-    //Ok(packet)
     Ok(())
 }