Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handlebar copyright comments are not being honored #829

Closed
trentjeff opened this issue Dec 15, 2022 · 7 comments
Closed

Handlebar copyright comments are not being honored #829

trentjeff opened this issue Dec 15, 2022 · 7 comments
Assignees

Comments

@trentjeff
Copy link
Member

See helidon-io/helidon#5598

The above PR introduces an .hbs file with a copyright comment on the header that should have been found. However, it resulted in an error:
`
error: Rule copyright failed. Errors:
error: pico/tools/src/main/java/io/helidon/pico/tools/Item.java:0: Expecting copyright with "13" lines, but it was "empty"
error: pico/tools/src/test/resources/templates/pico/default/module-info.hbs:1: No comment found

`

@trentjeff
Copy link
Member Author

Needed for 4.x builds.

@trentjeff
Copy link
Member Author

@trentjeff
Copy link
Member Author

@romain-grecourt @barchetta fyi

@romain-grecourt
Copy link
Contributor

This is fixed in master and will be included in the upcoming 3.0.2 release.

@trentjeff
Copy link
Member Author

Are you also planning to remove the exclusion? If not I can... just need to know..

@romain-grecourt
Copy link
Contributor

What exclusion ?

@romain-grecourt
Copy link
Contributor

There is nothing to do for this in build-tools except releasing 3.0.2. If we need to track the removal of the copyright exclusion then this should be done in the main repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants