-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handlebar copyright comments are not being honored #829
Comments
Needed for 4.x builds. |
Once fixed here, we need to remove the .hbs exclusion from https://github.com/helidon-io/helidon/pull/5598/files/b44c3b9172d31bad4e444a3bf0e39a47dfcb969d#diff-cb49f03cb4086001b091019c065d02a38af643b135d1b2f879de098b89435cd5 |
This is fixed in master and will be included in the upcoming 3.0.2 release. |
Are you also planning to remove the exclusion? If not I can... just need to know.. |
What exclusion ? |
There is nothing to do for this in build-tools except releasing 3.0.2. If we need to track the removal of the copyright exclusion then this should be done in the main repository. |
See helidon-io/helidon#5598
The above PR introduces an .hbs file with a copyright comment on the header that should have been found. However, it resulted in an error:
`
error: Rule copyright failed. Errors:
error: pico/tools/src/main/java/io/helidon/pico/tools/Item.java:0: Expecting copyright with "13" lines, but it was "empty"
error: pico/tools/src/test/resources/templates/pico/default/module-info.hbs:1: No comment found
`
The text was updated successfully, but these errors were encountered: