Pico Tools - Part 1 of N #5598
Pico Tools - Part 1 of N #5598
Conversation
oracle-contributor-agreement
bot
added
the
OCA Verified
etc/copyright-exclude.txt
Outdated
| @@ -66,3 +66,5 @@ persistence_3_0.xjb | |||
| persistence_3_0.xsd | |||
| # excluded as this is a test file and we need to validate its content | |||
| src/test/resources/static/classpath/index.html | |||
| .hbs | |||
There was a problem hiding this comment.
We do support handlebars copyright check, so we should not exclude it. Use {{! and }} for multiline comments
There was a problem hiding this comment.
I am a bit surprised to hear you say that we support it since I added a new dependency to JKnack handlebars, and it seems I am the first to use anything in 3.x or 4.x for .hbs files in any other cases.
Fwiw, I tried to use the convention suggested and it failed the checkstyle check. I will put it in my commit anyway for you to review.
There was a problem hiding this comment.
Follow-up will file bug on buildtools, and create a follow-up task here to remove .hbs exclusion.
There was a problem hiding this comment.
pico/tools/src/main/java/io/helidon/pico/tools/ModuleInfoDescriptor.java
Outdated
Show resolved
Hide resolved
pico/tools/src/main/java/io/helidon/pico/tools/ModuleInfoDescriptor.java
Outdated
Show resolved
Hide resolved
pico/tools/src/main/java/io/helidon/pico/tools/ModuleInfoDescriptor.java
Show resolved
Hide resolved
pico/tools/src/main/java/io/helidon/pico/tools/TemplateHelper.java
Outdated
Show resolved
Hide resolved
|
@barchetta FYI this is adding a new dep on Handlebars for production use w/in Helidon. |
trentjeff
force-pushed
the
pico-tools-1
branch
from
2511966 to
c595932
Compare
No description provided.