Review issues

helidon-io · Jun 7, 2023 · 0f5adda · 0f5adda
1 parent 72eec08
commit 0f5adda
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/nima/http2/http2/src/main/java/io/helidon/nima/http2/Http2Headers.java b/nima/http2/http2/src/main/java/io/helidon/nima/http2/Http2Headers.java
@@ -452,7 +452,7 @@ static BufferData[] split(BufferData bufferData, int size) {
         BufferData[] result = new BufferData[allFrames];
 
         for (int i = 0; i < allFrames; i++) {
-            boolean lastFrame = allFrames == i + 1;
+            boolean lastFrame = (allFrames == i + 1);
             byte[] frag = new byte[lastFrame ? (lastFragmentSize != 0 ? lastFragmentSize : size) : size];
             bufferData.read(frag);
             result[i] = BufferData.create(frag);

diff --git a/...ttp2/client/src/test/java/io/helidon/nima/tests/integration/http2/client/HeadersTest.java b/...ttp2/client/src/test/java/io/helidon/nima/tests/integration/http2/client/HeadersTest.java
@@ -95,7 +95,7 @@ static void beforeAll() throws ExecutionException, InterruptedException, Timeout
                         default -> res.setStatusCode(404).end();
                     }
                 })
-                .listen(8080)
+                .listen(0)
                 .toCompletionStage()
                 .toCompletableFuture()
                 .get(TIMEOUT.toMillis(), MILLISECONDS);
@@ -137,7 +137,6 @@ void trailerHeader() {
 
     @Test
     void continuationInbound() {
-        System.out.println("http://localhost:" + port + "/");
         try (Http2ClientResponse res = WebClient.builder(Http2.PROTOCOL)
                 .baseUri("http://localhost:" + port + "/")
                 .build()
@@ -158,7 +157,6 @@ void continuationInbound() {
 
     @Test
     void continuationOutbound() {
-        System.out.println("http://localhost:" + port + "/");
         Set<String> expected = new HashSet<>(500);
         try (Http2ClientResponse res = WebClient.builder(Http2.PROTOCOL)
                 .baseUri("http://localhost:" + port + "/")
@@ -181,7 +179,6 @@ void continuationOutbound() {
 
     @Test
     void continuationOutboundPost() {
-        System.out.println("http://localhost:" + port + "/");
         Set<String> expected = new HashSet<>(500);
         try (Http2ClientResponse res = WebClient.builder(Http2.PROTOCOL)
                 .baseUri("http://localhost:" + port + "/")

diff --git a/...2/server/src/test/java/io/helidon/nima/tests/integration/http2/webserver/HeadersTest.java b/...2/server/src/test/java/io/helidon/nima/tests/integration/http2/webserver/HeadersTest.java
@@ -53,7 +53,7 @@ public class HeadersTest {
 
     @SetUpServer
     static void setUpServer(WebServer.Builder serverBuilder) {
-        serverBuilder.port(8080)
+        serverBuilder.port(-1)
                 // HTTP/2 prior knowledge config
                 .addConnectionProvider(Http2ConnectionProvider.builder()
                         .http2Config(Http2ConfigDefault.builder()