Fixes logging message and test.

helidon-io · May 21, 2024 · 57868fd · 57868fd
1 parent 7ad594f
commit 57868fd
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/webclient/grpc/src/main/java/io/helidon/webclient/grpc/GrpcClientCall.java b/webclient/grpc/src/main/java/io/helidon/webclient/grpc/GrpcClientCall.java
@@ -116,7 +116,6 @@ protected void startStreamingThreads() {
                         Thread.sleep(period);
                         if (sendingQueue.isEmpty()) {
                             sendingQueue.add(PING_FRAME);
-                            socket().log(LOGGER, DEBUG, "[Heartbeat thread] heartbeat queued");
                         }
                     }
                 } catch (Throwable t) {
@@ -140,6 +139,7 @@ protected void startStreamingThreads() {
                     if (bufferData != null) {
                         if (bufferData == PING_FRAME) {                   // ping frame
                             clientStream().sendPing();
+                            socket().log(LOGGER, DEBUG, "[Writing thread] heartbeat sent");
                             continue;
                         }
                         if (bufferData == EMPTY_BUFFER_DATA) {            // end marker

diff --git a/.../webclient/grpc/tests/GrpcConfigTest.java → ...nt/grpc/tests/GrpcConfigProtocolTest.java b/.../webclient/grpc/tests/GrpcConfigTest.java → ...nt/grpc/tests/GrpcConfigProtocolTest.java
@@ -37,6 +37,7 @@ void testDefaults() {
         assertThat(config.pollWaitTime(), is(Duration.ofSeconds(10)));
         assertThat(config.abortPollTimeExpired(), is(false));
         assertThat(config.initBufferSize(), is(2048));
+        assertThat(config.heartbeatPeriod(), is(Duration.ofSeconds(0)));
     }
 
     @Test
@@ -46,5 +47,6 @@ void testApplicationConfig() {
         assertThat(config.pollWaitTime(), is(Duration.ofSeconds(30)));
         assertThat(config.abortPollTimeExpired(), is(true));
         assertThat(config.initBufferSize(), is(10000));
+        assertThat(config.heartbeatPeriod(), is(Duration.ofSeconds(10)));
     }
 }
diff --git a/webclient/tests/grpc/src/test/resources/application.yaml b/webclient/tests/grpc/src/test/resources/application.yaml
@@ -17,4 +17,5 @@
 grpc-client:
   poll-wait-time: PT30S
   abort-poll-time-expired: true
-  init-buffer-size: 10000
+  init-buffer-size: 10000
+  heartbeat-period: PT10S