Comment reviews

Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>

common/configurable/src/main/java/module-info.java

@@ -24,7 +24,6 @@
     requires io.helidon.builder.api;
     requires io.helidon.common.context;
     requires java.management;
-    requires java.logging;
 
     requires transitive io.helidon.common.config;
     requires transitive io.helidon.common;

common/configurable/src/test/java/io/helidon/common/configurable/ThreadPoolTest.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2019, 2022 Oracle and/or its affiliates.
+ * Copyright (c) 2019, 2024 Oracle and/or its affiliates.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -27,9 +27,6 @@
 import java.util.concurrent.atomic.AtomicInteger;
 import java.util.function.Function;
 import java.util.function.Supplier;
-import java.util.logging.Handler;
-import java.util.logging.LogRecord;
-import java.util.logging.Logger;
 import java.util.stream.IntStream;
 
 import org.awaitility.core.ConditionTimeoutException;
@@ -279,40 +276,6 @@ void testNullRejectionPolicy() {
         ), "rejectionPolicy is null");
     }
 
-    @Test
-    void testCannotChangeMaxPoolSize() {
-        pool = newPool(2, 2, 100, 25);
-        Logger log = Logger.getLogger(ThreadPool.class.getName());
-        assertThat(log.getHandlers().length, is(0));
-        assertThat(log.getUseParentHandlers(), is(true));
-        List<LogRecord> logRecords = new ArrayList<>();
-        Handler handler = new Handler() {
-            @Override
-            public void publish(LogRecord record) {
-                logRecords.add(record);
-            }
-
-            @Override
-            public void flush() {
-            }
-
-            @Override
-            public void close() throws SecurityException {
-            }
-        };
-
-        try {
-            log.addHandler(handler);
-            assertThat(pool.getMaximumPoolSize(), is(2));
-            pool.setMaximumPoolSize(4);
-            assertThat(pool.getMaximumPoolSize(), is(2));
-            assertThat(logRecords.size(), is(1));
-            assertThat(logRecords.get(0).getMessage(), containsString("cannot be changed"));
-        } finally {
-            log.removeHandler(handler);
-        }
-    }
-
     @Test
     void testSetRejectionHandlerRequiresRejectionPolicy() {
         pool = newPool(2, 2, 100, 25);

helidon/src/main/java/module-info.java

@@ -21,7 +21,6 @@
     // this is required due to a bug in JDK (see Main for details and link)
     requires java.logging;
 
-
     requires io.helidon.common;
     requires io.helidon.logging.common;
 

webserver/observe/log/src/main/java/module-info.java

@@ -41,5 +41,4 @@
 
     provides io.helidon.webserver.observe.spi.ObserveProvider
             with io.helidon.webserver.observe.log.LogObserveProvider;
-
 }