Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support of OCI Vault into Helidon #2416

Closed
paulparkinson opened this issue Oct 6, 2020 · 4 comments · Fixed by #2894
Closed

Add Support of OCI Vault into Helidon #2416

paulparkinson opened this issue Oct 6, 2020 · 4 comments · Fixed by #2894
Assignees
Labels

Comments

@paulparkinson
Copy link
Contributor

paulparkinson commented Oct 6, 2020

This is the same topic as #2395 "Add Support of Hashicorp Vault into Helidon" but specifically the OCI Vault service and, like that ER, we are researching best approaches to this particularly as there are a number of solutions and approaches in this area.

@paulparkinson paulparkinson added enhancement New feature or request P3 labels Oct 6, 2020
@paulparkinson paulparkinson self-assigned this Oct 6, 2020
@arjav-desai arjav-desai self-assigned this Dec 17, 2020
@tomas-langer
Copy link
Member

It would be good to understand what features are desired for OCI vaults (ideally with a reference to an SDK function, or REST API).
After playing around with the SDK, it seems there is no way to retrieve the actual secret value from a Vault, which seems to be the real use case I can see here.

I do not think that creating/updating secrets is the usual use case (please let me know if this assumption is wrong).

@tomas-langer
Copy link
Member

Found the getSecretBundle() method that can actually return secret content, looking into it.

@tomas-langer
Copy link
Member

tomas-langer commented Mar 27, 2021

Notes for follow up

DONE

  • Add CDI support for reactive interfaces, so this can be tested in an MP application
  • Add blocking APIs + CDI support for injecting them
  • Validate all modules exist in bom/pom.xml
  • Add CDI examples
  • Validate reactive examples work with native-image
  • Update FeatureCatalog with the new modules
  • Validate module-info.java exists for all modules (except for examples)
  • Validate an example using module path with full module info for both SE and MP

TODO:

@tomas-langer tomas-langer added epic and removed P3 labels Apr 20, 2021
@tomas-langer tomas-langer reopened this Apr 22, 2021
@m0mus m0mus changed the title Add Support of OCI Vault into Helidon OCI integration May 28, 2021
@m0mus m0mus added the OCI label May 28, 2021
@arjav-desai arjav-desai changed the title OCI integration Add Support of OCI Vault into Helidon May 28, 2021
@arjav-desai arjav-desai removed the epic label May 28, 2021
@trentjeff
Copy link
Member

Discussed with @tomas-langer , we can close this issue.

@m0mus m0mus added this to Backlog Aug 12, 2024
@m0mus m0mus moved this to Closed in Backlog Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants