Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary synchronization in ContentReaders::byteArrayReader() #573

Closed
spericas opened this issue Apr 15, 2019 · 0 comments
Closed

Unnecessary synchronization in ContentReaders::byteArrayReader() #573

spericas opened this issue Apr 15, 2019 · 0 comments
Assignees
@spericas
Labels
SE webserver

Comments

@spericas
Copy link
Member

spericas commented Apr 15, 2019 •
edited
Loading

The reader that converts a Flow into a ByteArray has unnecessary synchronization in onNext. According to the contract defined in Flow, calls to onNext are never executed concurrently. Note that OriginThreadPublisher uses a lock to guarantee this condition.
@spericas spericas added the enhancement New feature or request label Apr 15, 2019
@spericas spericas self-assigned this Apr 15, 2019
@m0mus m0mus added webserver SE and removed enhancement New feature or request labels Apr 15, 2019
spericas added a commit to spericas/helidon that referenced this issue Apr 16, 2019
@spericas
Removed unnecessary synchronization. See helidon-io#573.
1dab125 
Signed-off-by: Santiago Pericas-Geertsen <Santiago.PericasGeertsen@oracle.com>
@spericas spericas mentioned this issue Apr 16, 2019
Merged
@m0mus m0mus added this to Backlog Aug 12, 2024
@m0mus m0mus moved this to Closed in Backlog Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spericas spericas

Labels
SE webserver
Projects
Backlog
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spericas @m0mus