Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

java-dataloader-3.1.0 has an invalid Automatic-Module-Name manifest entry #6133

Closed
aalmiray opened this issue Feb 9, 2023 · 1 comment · Fixed by #6940
Closed

java-dataloader-3.1.0 has an invalid Automatic-Module-Name manifest entry #6133

aalmiray opened this issue Feb 9, 2023 · 1 comment · Fixed by #6940
Assignees
Labels
bug Something isn't working P3

Comments

@aalmiray
Copy link

aalmiray commented Feb 9, 2023

Environment Details

  • Helidon Version: 3.1.1
  • Helidon SE, Helidon MP
  • JDK version: N/A
  • OS: N/A
  • Docker version (if applicable): N/A

Problem Description

java-dataloader is a transitive dependency

[INFO] +- io.helidon.graphql:helidon-graphql-server:jar:3.1.1:compile
[INFO] |  \- com.graphql-java:graphql-java:jar:17.4:compile
[INFO] |     +- com.graphql-java:java-dataloader:jar:3.1.0:compile
[INFO] |     \- org.antlr:antlr4-runtime:jar:4.9.2:runtime

Its manifest defines an invalid automatic module name

Caused by: java.lang.module.FindException: Automatic-Module-Name: com.graphql-java: Invalid module name: 'graphql-java' is not a Java identifier
	at java.base/jdk.internal.module.ModulePath.deriveModuleDescriptor(ModulePath.java:505)
	at java.base/jdk.internal.module.ModulePath.readJar(ModulePath.java:644)

v3.2.0 fixes this issue. I'd recommend upgrading when ready.

@m0mus m0mus added bug Something isn't working P3 labels Feb 9, 2023
@barchetta
Copy link
Member

barchetta commented Mar 30, 2023

The bad module name looks like it was first fixed in java-dataloader 3.1.1

And the first graphql-java release with this version (actually it has java-dataload 3.1.2) is 18

Both Helidon 2.x and 3.x are on graphql-java 17.5.

For 4.x see #6536

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P3
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants