Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.x: Upgrade graphql to 18.5 and scalars to 18.3 #6939

Merged
merged 3 commits into from
Jun 6, 2023
Merged

2.x: Upgrade graphql to 18.5 and scalars to 18.3 #6939

merged 3 commits into from
Jun 6, 2023

Conversation

barchetta
Copy link
Member

@barchetta barchetta commented Jun 2, 2023 •
edited
Loading

Upgrades graphql and fixes #6133

Tried 19.5 but it failed microprofile graphql tck.

@barchetta barchetta added 2.x Issues for 2.x version branch dependencies Pull requests that update a dependency file graphql labels Jun 2, 2023
@barchetta barchetta added this to the 2.6.2 milestone Jun 2, 2023
@barchetta barchetta requested a review from tmiddlet2666 June 2, 2023 00:38
@barchetta barchetta self-assigned this Jun 2, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jun 2, 2023
tmiddlet2666
tmiddlet2666 approved these changes Jun 2, 2023
View reviewed changes
Copy link
Collaborator

@tmiddlet2666 tmiddlet2666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tmiddlet2666
tmiddlet2666 previously approved these changes Jun 2, 2023
View reviewed changes
Copy link
Collaborator

@tmiddlet2666 tmiddlet2666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barchetta barchetta changed the title 2.x: Upgrade graphql to 19.5 and scalars to 19.1 2.x: Upgrade graphql to 18.5 and scalars to 18.3 Jun 2, 2023
tmiddlet2666
tmiddlet2666 approved these changes Jun 5, 2023
View reviewed changes
Copy link
Collaborator

@tmiddlet2666 tmiddlet2666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@barchetta barchetta merged commit cf22df7 into helidon-io:helidon-2.x Jun 6, 2023
@barchetta barchetta deleted the 2.x-upgrade-graphql branch August 14, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmiddlet2666 tmiddlet2666 tmiddlet2666 approved these changes

Assignees

@barchetta barchetta

Labels
2.x Issues for 2.x version branch dependencies Pull requests that update a dependency file graphql OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
2.6.2
Development

Successfully merging this pull request may close these issues.
2 participants
@barchetta @tmiddlet2666