Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pico shutdown should have a timeout configuration #6434

Closed
trentjeff opened this issue Mar 20, 2023 · 1 comment
Closed

Pico shutdown should have a timeout configuration #6434

trentjeff opened this issue Mar 20, 2023 · 1 comment
Assignees
Labels
4.x Version 4.x declarative Helidon Declarative
Milestone

Comments

@trentjeff
Copy link
Member

See DefaultPicoServices.doShutdown().

            return es.submit(shutdown)
                    // note to self: have an appropriate timeout config for this
//                    .get(cfg.activationDeadlockDetectionTimeoutMillis(), TimeUnit.MILLISECONDS);
                    .get();
@trentjeff trentjeff added 4.x Version 4.x declarative Helidon Declarative labels Mar 20, 2023
@trentjeff trentjeff added this to the 4.0.0 milestone Mar 20, 2023
@trentjeff trentjeff self-assigned this Mar 20, 2023
@trentjeff trentjeff modified the milestones: 4.0.0, 4.0.0-M1 Apr 17, 2023
@trentjeff trentjeff modified the milestones: 4.0.0-M1, 4.0.0-M2 May 4, 2023
trentjeff added a commit to trentjeff/helidon that referenced this issue Jul 17, 2023
@trentjeff
Copy link
Member Author

Most of this work apparently was already completed. Just putting some cleanup in #7051.

trentjeff added a commit that referenced this issue Jul 19, 2023
@m0mus m0mus added this to Backlog Aug 12, 2024
@m0mus m0mus moved this to Closed in Backlog Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x declarative Helidon Declarative
Projects
Archived in project
Development

No branches or pull requests

1 participant