Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uplevel nima #7164

Closed
barchetta opened this issue Jul 10, 2023 · 0 comments · Fixed by #7361
Closed

Uplevel nima #7164

barchetta opened this issue Jul 10, 2023 · 0 comments · Fixed by #7361
Assignees
@romain-grecourt
Labels
4.x Version 4.x Níma Helidon Níma webserver
Milestone
4.0.0-M2

Comments

@barchetta
Copy link
Member

barchetta commented Jul 10, 2023 •
edited by tomas-langer
Loading

Eliminate nima from module names, java package names, class names, directory/file names, and APIs in general. This will result in the contents of the nima module being flattened into the top level directory structure.

Nima is the code name for the Helidon 4 webserver built on virtual threads -- but we don't want that code name to appear in Helidon APIs.

Depends on #7255

Either as part of this fix, or as a follow up, we should also do this:

  • move protocol specific modules for webclient and webserver to webclient and webserver moduules
    Currently we have:
helidon-http2-webclient
helidon-htttp2-webserver
helidon-websocket-client
helidon-websocket-webserver
...

what we should have:

helidon-webclient-http2
helidon-webserver-http2
helidon-webclient-websocket
helidon-webserver-websocket
...

The common classes will stay in the protocol dedicated module (e.g. helidon-http2). There is an option here to break our naming rules, and keep the location of the modules as they are now, and only change the artifact-id and packages to the desired place. Open for discussion...
@barchetta barchetta added webserver 4.x Version 4.x Níma Helidon Níma labels Jul 10, 2023
@barchetta barchetta added this to the 4.0.0-M2 milestone Jul 10, 2023
This was referenced Aug 8, 2023
Closed
Closed
romain-grecourt added a commit to romain-grecourt/helidon that referenced this issue Aug 11, 2023
@romain-grecourt
Uplevel Nima
bb397e3 
Fixes helidon-io#7164

/nima/http -> /http
/nima/http2 -> /http/http2
/common/http -> /http/http
/nima/webclient -> /webclient
/nima/webserver -> /webserver
/nima/websocket/websocket -> /websocket
/nima/websocket/webserver -> /webserver/websocket
/nima/websocket/webclient -> /webclient/websocket
/nima/sse -> /http/sse
/nima/observe -> /webserver/observe
/nima/test -> /webserver/testing
/nima/fault-tolerance -> /fault-tolerance
/nima/service-common -> /webserver/service-common
/nima/graphql/server -> /webserver/graphql
/nima/common/tls -> /common/tls
/security/integration/nima -> /webserver/security
/nima/tests/webserver -> /webserver/tests
/nima/tests/websocket/server -> /webserver/tests/websocket
/nima/tests/http2/server -> /webserver/tests/http2
/nima/tests/observe -> /webserver/tests/observe
/nima/tests/grpc -> /webserver/tests/grpc
/nima/tests/sse/server -> /webserver/tests/sse
/tests/integration/webserver/* -> /webserver/tests/
/nima/tests/webclient -> /webclient/tests
/nima/tests/http2/client -> /webclient/tests/http2
/tests/integration/webclient -> /webclient/tests/
/nima/tests/encoding -> /http/tests/encoding
/nima/tests/logging/log4j -> /logging/tests/log4j
/nima/tests/media -> /http/tests/media
@romain-grecourt romain-grecourt mentioned this issue Aug 11, 2023
Merged
romain-grecourt added a commit to romain-grecourt/helidon that referenced this issue Aug 12, 2023
@romain-grecourt
Uplevel Nima
bd8d2d8 
Fixes helidon-io#7164
Fixes helidon-io#7339

Refactoring:

/nima/http -> /http
/nima/http2 -> /http/http2
/common/http -> /http/http
/nima/webclient -> /webclient
/nima/webserver -> /webserver
/nima/websocket/websocket -> /websocket
/nima/websocket/webserver -> /webserver/websocket
/nima/websocket/webclient -> /webclient/websocket
/nima/sse -> /http/sse
/nima/observe -> /webserver/observe
/nima/test -> /webserver/testing
/nima/fault-tolerance -> /fault-tolerance
/nima/service-common -> /webserver/service-common
/nima/graphql/server -> /webserver/graphql
/nima/common/tls -> /common/tls
/security/integration/nima -> /webserver/security
/nima/tests/webserver -> /webserver/tests
/nima/tests/websocket/server -> /webserver/tests/websocket
/nima/tests/http2/server -> /webserver/tests/http2
/nima/tests/observe -> /webserver/tests/observe
/nima/tests/grpc -> /webserver/tests/grpc
/nima/tests/sse/server -> /webserver/tests/sse
/tests/integration/webserver/* -> /webserver/tests/
/nima/tests/webclient -> /webclient/tests
/nima/tests/http2/client -> /webclient/tests/http2
/tests/integration/webclient -> /webclient/tests/
/nima/tests/encoding -> /http/tests/encoding
/nima/tests/logging/log4j -> /logging/tests/log4j
/nima/tests/media -> /http/tests/media

Remove leftover occurrences of Nima, Níma, nima
romain-grecourt added a commit to romain-grecourt/helidon that referenced this issue Aug 15, 2023
@romain-grecourt
Uplevel Nima
9b74604 
Fixes helidon-io#7164
Fixes helidon-io#7339

- Refactoring:

/nima/http -> /http
/nima/http2 -> /http/http2
/common/http -> /http/http
/nima/webclient -> /webclient
/nima/webserver -> /webserver
/nima/websocket/websocket -> /websocket
/nima/websocket/webserver -> /webserver/websocket
/nima/websocket/webclient -> /webclient/websocket
/nima/sse -> /http/sse
/nima/observe -> /webserver/observe
/nima/test -> /webserver/testing
/nima/fault-tolerance -> /fault-tolerance
/nima/service-common -> /webserver/service-common
/nima/graphql/server -> /webserver/graphql
/nima/common/tls -> /common/tls
/security/integration/nima -> /webserver/security
/nima/tests/webserver -> /webserver/tests
/nima/tests/websocket/server -> /webserver/tests/websocket
/nima/tests/http2/server -> /webserver/tests/http2
/nima/tests/observe -> /webserver/tests/observe
/nima/tests/grpc -> /webserver/tests/grpc
/nima/tests/sse/server -> /webserver/tests/sse
/tests/integration/webserver/* -> /webserver/tests/
/nima/tests/webclient -> /webclient/tests
/nima/tests/http2/client -> /webclient/tests/http2
/tests/integration/webclient -> /webclient/tests/
/nima/tests/encoding -> /http/tests/encoding
/nima/tests/logging/log4j -> /logging/tests/log4j
/nima/tests/media -> /http/tests/media

- Remove leftover occurrences of Nima, Níma, nima, NIMA
- Fix ModuleInfoDescriptorBlueprint.mergeCreate
- Fix WebServer feature definition
- Fix Neo4J feature definition
- Update keystores in webserver/tests/mtl (to get rid of 'nima' references)
romain-grecourt added a commit to romain-grecourt/helidon that referenced this issue Aug 15, 2023
@romain-grecourt
Uplevel Nima
4d59a15 
Fixes helidon-io#7164
Fixes helidon-io#7339

- Refactoring:

/nima/http -> /http
/nima/http2 -> /http/http2
/common/http -> /http/http
/nima/webclient -> /webclient
/nima/webserver -> /webserver
/nima/websocket/websocket -> /websocket
/nima/websocket/webserver -> /webserver/websocket
/nima/websocket/webclient -> /webclient/websocket
/nima/sse -> /http/sse
/nima/observe -> /webserver/observe
/nima/test -> /webserver/testing
/nima/fault-tolerance -> /fault-tolerance
/nima/service-common -> /webserver/service-common
/nima/graphql/server -> /webserver/graphql
/nima/common/tls -> /common/tls
/security/integration/nima -> /webserver/security
/nima/tests/webserver -> /webserver/tests
/nima/tests/websocket/server -> /webserver/tests/websocket
/nima/tests/http2/server -> /webserver/tests/http2
/nima/tests/observe -> /webserver/tests/observe
/nima/tests/grpc -> /webserver/tests/grpc
/nima/tests/sse/server -> /webserver/tests/sse
/tests/integration/webserver/* -> /webserver/tests/
/nima/tests/webclient -> /webclient/tests
/nima/tests/http2/client -> /webclient/tests/http2
/tests/integration/webclient -> /webclient/tests/
/nima/tests/encoding -> /http/tests/encoding
/nima/tests/logging/log4j -> /logging/tests/log4j
/nima/tests/media -> /http/tests/media

- Remove leftover occurrences of Nima, Níma, nima, NIMA
- Fix ModuleInfoDescriptorBlueprint.mergeCreate
- Fix WebServer feature definition
- Fix Neo4J feature definition
- Update keystores in webserver/tests/mtl (to get rid of 'nima' references)
romain-grecourt added a commit to romain-grecourt/helidon that referenced this issue Aug 16, 2023
@romain-grecourt
Uplevel Nima
f9e2682 
Fixes helidon-io#7164
Fixes helidon-io#7339

- Refactoring:

/nima/http -> /http
/nima/http2 -> /http/http2
/common/http -> /http/http
/nima/webclient -> /webclient
/nima/webserver -> /webserver
/nima/websocket/websocket -> /websocket
/nima/websocket/webserver -> /webserver/websocket
/nima/websocket/webclient -> /webclient/websocket
/nima/sse -> /http/sse
/nima/observe -> /webserver/observe
/nima/test -> /webserver/testing
/nima/fault-tolerance -> /fault-tolerance
/nima/service-common -> /webserver/service-common
/nima/graphql/server -> /webserver/graphql
/nima/common/tls -> /common/tls
/security/integration/nima -> /webserver/security
/nima/tests/webserver -> /webserver/tests
/nima/tests/websocket/server -> /webserver/tests/websocket
/nima/tests/http2/server -> /webserver/tests/http2
/nima/tests/observe -> /webserver/tests/observe
/nima/tests/grpc -> /webserver/tests/grpc
/nima/tests/sse/server -> /webserver/tests/sse
/tests/integration/webserver/* -> /webserver/tests/
/nima/tests/webclient -> /webclient/tests
/nima/tests/http2/client -> /webclient/tests/http2
/tests/integration/webclient -> /webclient/tests/
/nima/tests/encoding -> /http/tests/encoding
/nima/tests/logging/log4j -> /logging/tests/log4j
/nima/tests/media -> /http/tests/media

- Remove leftover occurrences of Nima, Níma, nima, NIMA
- Fix ModuleInfoDescriptorBlueprint.mergeCreate
- Fix WebServer feature definition
- Fix Neo4J feature definition
- Update keystores in webserver/tests/mtls (to get rid of 'nima' references)
@romain-grecourt romain-grecourt linked a pull request Aug 16, 2023 that will close this issue
Uplevel Nima #7361
Merged
romain-grecourt added a commit to romain-grecourt/helidon that referenced this issue Aug 16, 2023
@romain-grecourt
Uplevel Nima
c521c86 
Fixes helidon-io#7164
Fixes helidon-io#7339

- Refactoring:

/nima/http -> /http
/nima/http2 -> /http/http2
/common/http -> /http/http
/nima/webclient -> /webclient
/nima/webserver -> /webserver
/nima/websocket/websocket -> /websocket
/nima/websocket/webserver -> /webserver/websocket
/nima/websocket/webclient -> /webclient/websocket
/nima/sse -> /http/sse
/nima/observe -> /webserver/observe
/nima/test -> /webserver/testing
/nima/fault-tolerance -> /fault-tolerance
/nima/service-common -> /webserver/service-common
/nima/graphql/server -> /webserver/graphql
/nima/common/tls -> /common/tls
/security/integration/nima -> /webserver/security
/nima/tests/webserver -> /webserver/tests
/nima/tests/websocket/server -> /webserver/tests/websocket
/nima/tests/http2/server -> /webserver/tests/http2
/nima/tests/observe -> /webserver/tests/observe
/nima/tests/grpc -> /webserver/tests/grpc
/nima/tests/sse/server -> /webserver/tests/sse
/tests/integration/webserver/* -> /webserver/tests/
/nima/tests/webclient -> /webclient/tests
/nima/tests/http2/client -> /webclient/tests/http2
/tests/integration/webclient -> /webclient/tests/
/nima/tests/encoding -> /http/tests/encoding
/nima/tests/logging/log4j -> /logging/tests/log4j
/nima/tests/media -> /http/tests/media

- Remove leftover occurrences of Nima, Níma, nima, NIMA
- Fix ModuleInfoDescriptorBlueprint.mergeCreate
- Fix WebServer feature definition
- Fix Neo4J feature definition
- Update keystores in webserver/tests/mtls (to get rid of 'nima' references)
romain-grecourt added a commit that referenced this issue Aug 16, 2023
@romain-grecourt
Uplevel Nima (#7361)
43aaf9e 
Fixes #7164
Fixes #7339

- Refactoring:

/nima/http -> /http
/nima/http2 -> /http/http2
/common/http -> /http/http
/nima/webclient -> /webclient
/nima/webserver -> /webserver
/nima/websocket/websocket -> /websocket
/nima/websocket/webserver -> /webserver/websocket
/nima/websocket/webclient -> /webclient/websocket
/nima/sse -> /http/sse
/nima/observe -> /webserver/observe
/nima/test -> /webserver/testing
/nima/fault-tolerance -> /fault-tolerance
/nima/service-common -> /webserver/service-common
/nima/graphql/server -> /webserver/graphql
/nima/common/tls -> /common/tls
/security/integration/nima -> /webserver/security
/nima/tests/webserver -> /webserver/tests
/nima/tests/websocket/server -> /webserver/tests/websocket
/nima/tests/http2/server -> /webserver/tests/http2
/nima/tests/observe -> /webserver/tests/observe
/nima/tests/grpc -> /webserver/tests/grpc
/nima/tests/sse/server -> /webserver/tests/sse
/tests/integration/webserver/* -> /webserver/tests/
/nima/tests/webclient -> /webclient/tests
/nima/tests/http2/client -> /webclient/tests/http2
/tests/integration/webclient -> /webclient/tests/
/nima/tests/encoding -> /http/tests/encoding
/nima/tests/logging/log4j -> /logging/tests/log4j
/nima/tests/media -> /http/tests/media

- Remove leftover occurrences of Nima, Níma, nima, NIMA
- Fix ModuleInfoDescriptorBlueprint.mergeCreate
- Fix WebServer feature definition
- Fix Neo4J feature definition
- Update keystores in webserver/tests/mtls (to get rid of 'nima' references)
@m0mus m0mus added this to Backlog Aug 12, 2024
@m0mus m0mus moved this to Closed in Backlog Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romain-grecourt romain-grecourt

Labels
4.x Version 4.x Níma Helidon Níma webserver
Projects
Backlog
Archived in project
Milestone
4.0.0-M2
Development

Successfully merging a pull request may close this issue.

Uplevel Nima romain-grecourt/helidon
2 participants
@romain-grecourt @barchetta