Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LoomServer does not update internal state when listener fails to start #8109

Closed
spericas opened this issue Dec 6, 2023 · 0 comments · Fixed by #8111
Closed

LoomServer does not update internal state when listener fails to start #8109

spericas opened this issue Dec 6, 2023 · 0 comments · Fixed by #8111
Assignees
@spericas
Labels
4.x Version 4.x webserver
Milestone
4.0.2

Comments

@spericas
Copy link
Member

spericas commented Dec 6, 2023

If a listener fails to start (for example because of an unsupported TLS setting), the error is logged but the server's isRunning method still returns true after shutting down all other listeners. Internal server state needs to reflect failure to start. See LoomServer::startIt.
@spericas spericas added webserver 4.x Version 4.x labels Dec 6, 2023
@spericas spericas self-assigned this Dec 6, 2023
@spericas spericas added this to the 4.0.2 milestone Dec 6, 2023
@barchetta barchetta linked a pull request Dec 7, 2023 that will close this issue
Update server's internal state if a listener fails to start #8111
Merged
@barchetta barchetta mentioned this issue Dec 7, 2023
Merged
@m0mus m0mus added this to Backlog Aug 12, 2024
@m0mus m0mus moved this to Closed in Backlog Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spericas spericas

Labels
4.x Version 4.x webserver
Projects
Backlog
Archived in project
Milestone
4.0.2
Development

Successfully merging a pull request may close this issue.

Update server's internal state if a listener fails to start spericas/helidon
1 participant
@spericas