Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update server's internal state if a listener fails to start #8111

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Update server's internal state if a listener fails to start #8111

merged 1 commit into from
Dec 7, 2023

Conversation

spericas
Copy link
Member

@spericas spericas commented Dec 7, 2023 •
edited by barchetta
Loading

Description

Update server's internal state if a listener fails to start for some reason. Calls to isRunning must return false if listeners failed to start and the server isn't listening for connections.

Fixes #8109

Documentation

None

@spericas spericas added bug Something isn't working 4.x Version 4.x labels Dec 7, 2023
@spericas spericas added this to the 4.0.2 milestone Dec 7, 2023
@spericas spericas self-assigned this Dec 7, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Dec 7, 2023
@spericas spericas changed the title Update server's internal state if a listener fails to start for some … Update server's internal state if a listener fails to start Dec 7, 2023
@barchetta barchetta linked an issue Dec 7, 2023 that may be closed by this pull request
LoomServer does not update internal state when listener fails to start #8109
Closed
@spericas spericas requested a review from barchetta December 7, 2023 18:59
@spericas spericas merged commit 94f1349 into helidon-io:main Dec 7, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barchetta barchetta barchetta approved these changes

@danielkec danielkec Awaiting requested review from danielkec

@romain-grecourt romain-grecourt Awaiting requested review from romain-grecourt

Assignees

@spericas spericas

Labels
4.x Version 4.x bug Something isn't working OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
4.0.2
Development

Successfully merging this pull request may close these issues.

LoomServer does not update internal state when listener fails to start
2 participants
@spericas @barchetta