Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x: Different defaults for HTTP/1.1 limits #9002

Closed
tomas-langer opened this issue Jul 17, 2024 · 0 comments · Fixed by #9007
Closed

4.x: Different defaults for HTTP/1.1 limits #9002

tomas-langer opened this issue Jul 17, 2024 · 0 comments · Fixed by #9007
Assignees
Labels
4.x Version 4.x bug Something isn't working P2 webserver

Comments

@tomas-langer
Copy link
Member

Limits in 3.x (in io.helidon.webserver.SocketConfiguration.Builder):

 private int maxHeaderSize = 16384;
private int maxInitialLineLength = 4096;

in 4.x, we have the limits set to (in io.helidon.webserver.http1.Http1ConfigBlueprint):

@Option.DefaultInt(16384) // correct
int maxHeadersSize(); 

@Option.DefaultInt(2048) // should be 4096
int maxPrologueLength();

Other defaults should be checked as well and aligned where the semantics is the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x bug Something isn't working P2 webserver
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants