Add tolerance to metrics tests; widen tolerance used during pipeline runs (2.x) #1999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… runs Signed-off-by: tim.quinn@oracle.com <tim.quinn@oracle.com>
tjquinno
changed the title
barchetta
approved these changes
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially resolves #1998 (for 2.x; 1.x will be separate)
More pipeline runs were beginning to show intermittent test failures in metrics. These changes use a tolerance (instead of direct equality checks) on more tests to try to insulate the test results from variations in execution timing and speed.
Signed-off-by: tim.quinn@oracle.com tim.quinn@oracle.com