Buffer single-byte writes in MultiFromOutputStream for better performance #2133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… written one at a time to avoid publishing single-byte data chunks. The logic remains the same for byte array writes. Some new tests. Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
danielkec
reviewed
Jul 8, 2020
common/reactive/src/test/java/io/helidon/common/reactive/MultiFromOutputStreamTest.java
Outdated
Show resolved
Hide resolved
danielkec
reviewed
Jul 8, 2020
common/reactive/src/test/java/io/helidon/common/reactive/MultiFromOutputStreamTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
danielkec
approved these changes
Jul 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid publishing single-byte arrays whenever possible. Every single-byte write is cached until either the buffer is full or a multi-byte write is requested. Multi-byte writes (arrays) are never cached and always published immediately. Manual flushes still permitted as before. See #1833 for a discussion.