Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds META-INF/services file to native image configuration for Helidon MicroProfile CDI to resolve #2315 #2316

Closed
wants to merge 1 commit into from

Conversation

ljnelson
Copy link
Member

@ljnelson ljnelson commented Sep 2, 2020

Signed-off-by: Laird Nelson laird.nelson@oracle.com

… MicroProfile CDI to resolve #2315

Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
@ljnelson ljnelson requested a review from barchetta September 2, 2020 02:58
@ljnelson ljnelson linked an issue Sep 2, 2020 that may be closed by this pull request
@ljnelson ljnelson added 2.x Issues for 2.x version branch MP native-image P1 labels Sep 2, 2020
@ljnelson ljnelson added this to the 2.0.2 milestone Sep 2, 2020
@ljnelson ljnelson self-assigned this Sep 2, 2020
@ljnelson ljnelson marked this pull request as ready for review September 2, 2020 03:03
@ljnelson
Copy link
Member Author

ljnelson commented Sep 2, 2020

@tomas-langer @barchetta One question I have (since I know zero about GraalVM native image configuration) is if I also have to do something like this or if that's now obsolete.

@tomas-langer
Copy link
Member

Both META-INF/services and service implementations are added automatically. Let me investigate.

Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the fix. Please close this PR.

@tomas-langer
Copy link
Member

Fix in #2317

@ljnelson ljnelson closed this Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Issues for 2.x version branch MP native-image P1
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

native-image failing on io.helidon.microprofile.weld.ExecutorServices
2 participants