Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MP config instead of Config.create() in MP components. #3291

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,12 @@

import io.helidon.common.LazyValue;
import io.helidon.config.Config;
import io.helidon.config.mp.MpConfig;
import io.helidon.integrations.micrometer.MeterRegistryFactory;
import io.helidon.integrations.micrometer.MicrometerSupport;

import io.micrometer.core.instrument.MeterRegistry;
import org.eclipse.microprofile.config.ConfigProvider;

@ApplicationScoped
class MeterRegistryProducer {
Expand Down Expand Up @@ -55,7 +57,7 @@ static void clear() {
}

private static MicrometerSupport createMicrometerSupport() {
Config micrometerConfig = Config.create().get(CONFIG_KEY);
Config micrometerConfig = MpConfig.toHelidonConfig(ConfigProvider.getConfig()).get(CONFIG_KEY);
MeterRegistryFactory factory = MeterRegistryFactory.getInstance(
MeterRegistryFactory.builder()
.config(micrometerConfig));
Expand Down
1 change: 1 addition & 0 deletions integrations/micrometer/cdi/src/main/java/module-info.java
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
requires io.helidon.config;
requires io.helidon.webserver.cors;
requires io.helidon.integrations.micrometer;
requires io.helidon.config.mp;

requires micrometer.core;
requires micrometer.registry.prometheus;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -341,45 +341,45 @@ private List<Enrollment> explicitAndBuiltInEnrollments() {
* @param registriesConfig {@code Config} object for the 1 or more {@code builtin-registries} entries
*/
private void enrollBuiltInRegistries(Config registriesConfig) {

if (registriesConfig.type() != Config.Type.LIST) {
throw new IllegalArgumentException("Expected Micrometer config " + BUILTIN_REGISTRIES_CONFIG_KEY + " as a LIST "
+ "but found " + registriesConfig.type().name());
}

// in case config is created from MP config, node type is OBJECT instead of LIST
// as MP config flattens everything
Map<BuiltInRegistryType, MicrometerBuiltInRegistrySupport> candidateBuiltInRegistryTypes =
new HashMap<>();
List<String> unrecognizedTypes = new ArrayList<>();

for (Config registryConfig : registriesConfig.asNodeList().get()) {
String registryType = registryConfig.get("type").asString().get();
try {
BuiltInRegistryType type =
BuiltInRegistryType.valueByName(registryType);

MicrometerBuiltInRegistrySupport builtInRegistrySupport =
MicrometerBuiltInRegistrySupport.create(type, registryConfig.asNode());
if (builtInRegistrySupport != null) {
candidateBuiltInRegistryTypes.put(type, builtInRegistrySupport);
}
} catch (BuiltInRegistryType.UnrecognizedBuiltInRegistryTypeException e) {
unrecognizedTypes.add(e.unrecognizedType());
logRecords.add(new LogRecord(Level.WARNING,
String.format("Ignoring unrecognized Micrometer built-in registry type %s", e.unrecognizedType())));
}
}
registriesConfig.asList(Config.class)
.ifPresent(confList -> {
for (Config registryConfig : confList) {
String registryType = registryConfig.get("type").asString().get();
try {
BuiltInRegistryType type =
BuiltInRegistryType.valueByName(registryType);

MicrometerBuiltInRegistrySupport builtInRegistrySupport =
MicrometerBuiltInRegistrySupport.create(type, registryConfig.asNode());

candidateBuiltInRegistryTypes.put(type, builtInRegistrySupport);
} catch (BuiltInRegistryType.UnrecognizedBuiltInRegistryTypeException e) {
unrecognizedTypes.add(e.unrecognizedType());
logRecords.add(new LogRecord(Level.WARNING,
String.format(
"Ignoring unrecognized Micrometer built-in registry type %s",
e.unrecognizedType())));
}
}
});

if (!unrecognizedTypes.isEmpty()) {
LOGGER.log(Level.WARNING, String.format("Ignoring unrecognized Micrometer built-in registries: %s",
unrecognizedTypes.toString()));
unrecognizedTypes));
}

// Do not change previous settings if we did not find any valid new built-in registries selected.
if (!candidateBuiltInRegistryTypes.isEmpty()) {
builtInRegistriesRequested.clear();
builtInRegistriesRequested.putAll(candidateBuiltInRegistryTypes);
LOGGER.log(Level.FINE,
() -> "Selecting built-in Micrometer registries " + candidateBuiltInRegistryTypes.toString());
() -> "Selecting built-in Micrometer registries " + candidateBuiltInRegistryTypes);
}
}
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2018, 2020 Oracle and/or its affiliates.
* Copyright (c) 2018, 2021 Oracle and/or its affiliates.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -44,6 +44,7 @@

import io.helidon.common.configurable.ScheduledThreadPoolSupplier;
import io.helidon.common.configurable.ThreadPoolSupplier;
import io.helidon.config.mp.MpConfig;
import io.helidon.faulttolerance.FaultTolerance;

import org.eclipse.microprofile.config.Config;
Expand Down Expand Up @@ -270,7 +271,7 @@ void registerMetricsAndInitExecutors(@Observes AfterDeploymentValidation validat
}

// Initialize executors for MP FT - default size of 16
io.helidon.config.Config config = io.helidon.config.Config.create();
io.helidon.config.Config config = MpConfig.toHelidonConfig(ConfigProvider.getConfig());
scheduledThreadPoolSupplier = ScheduledThreadPoolSupplier.builder()
.threadNamePrefix("ft-mp-schedule-")
.corePoolSize(16)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
requires io.helidon.microprofile.config;
requires io.helidon.microprofile.server;
requires io.helidon.microprofile.metrics;
requires io.helidon.config.mp;

requires jakarta.enterprise.cdi.api;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@

import io.helidon.common.serviceloader.HelidonServiceLoader;
import io.helidon.config.Config;
import io.helidon.config.mp.MpConfig;
import io.helidon.grpc.server.GrpcRouting;
import io.helidon.grpc.server.GrpcServer;
import io.helidon.grpc.server.GrpcServerConfiguration;
Expand All @@ -51,6 +52,7 @@
import io.grpc.BindableService;
import io.grpc.Channel;
import io.grpc.inprocess.InProcessChannelBuilder;
import org.eclipse.microprofile.config.ConfigProvider;

/**
* A CDI extension that will start the {@link GrpcServer gRPC server}.
Expand All @@ -73,7 +75,7 @@ public class GrpcServerCdiExtension
private void startServer(@Observes @Initialized(ApplicationScoped.class) Object event, BeanManager beanManager) {
GrpcRouting.Builder routingBuilder = discoverGrpcRouting(beanManager);

Config config = resolveConfig(beanManager);
Config config = MpConfig.toHelidonConfig(ConfigProvider.getConfig());
GrpcServerConfiguration.Builder serverConfiguration = GrpcServerConfiguration.builder(config.get("grpc"));
CompletableFuture<GrpcServer> startedFuture = new CompletableFuture<>();
CompletableFuture<GrpcServer> shutdownFuture = new CompletableFuture<>();
Expand Down Expand Up @@ -129,26 +131,6 @@ private void stopServer(@Observes BeforeShutdown event) {
}
}

/**
* Resolve the Helidon configuration to use.
* <p>
* The a bean of type {@link Config} is resolvable then that
* bean will be used for the configuration otherwise a new
* configuration will be created using {@link Config#create()}.
*
* @param beanManager the {@link BeanManager} to use to resolve the config bean
*
* @return the {@link Config} to use
*/
private Config resolveConfig(BeanManager beanManager) {
Instance<Config> instance = beanManager.createInstance().select(Config.class);
if (instance.isResolvable()) {
return instance.get();
} else {
return Config.create();
}
}

/**
* Discover the services and interceptors to use to configure the
* {@link GrpcRouting}.
Expand Down
3 changes: 2 additions & 1 deletion microprofile/grpc/server/src/main/java/module-info.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2019, 2020 Oracle and/or its affiliates.
* Copyright (c) 2019, 2021 Oracle and/or its affiliates.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand All @@ -25,6 +25,7 @@
requires transitive io.helidon.microprofile.grpc.core;
requires io.helidon.common.serviceloader;
requires io.helidon.microprofile.server;
requires io.helidon.config.mp;

requires transitive io.grpc;
requires grpc.protobuf.lite;
Expand Down