[New Docs PR] - Helidon MP Reactive Messaging #4469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielkec
force-pushed
the
4215-reactive_docs
branch
2 times, most recently
from
3d14312 to
6437d44
Compare
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
danielkec
force-pushed
the
4215-reactive_docs
branch
from
6437d44 to
095ce1f
Compare
m0mus
approved these changes
Jul 13, 2022
romain-grecourt
pushed a commit
to MadsBrun/helidon
that referenced
this pull request
Jul 21, 2022
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
ljamen
reviewed
Aug 2, 2022
| Mock connector works great with built-in Helidon test support for | ||
| link:/{rootdir}/testing/testing.adoc[JUnit 5] or link:/{rootdir}/testing/testing-ng.adoc[Test NG]. | ||
|
|
||
| As Helidon test support makes a bean out of your test, you can inject MockConnector right in to it. |
There was a problem hiding this comment.
Mock Connector directly into it or is it MockConnector when referring to the bean?
| @@ -121,7 +121,7 @@ implicit ack before callback is executed is necessary. | |||
|
|
|||
| === Connector | |||
| Connector concept is a way for connecting <<Channel,channels>> to external sources. | |||
There was a problem hiding this comment.
Connector concept? Does this mean the concept of connecting channels to external sources or could it be "Connectors are used to connect channels to external sources."?
| @@ -121,7 +121,7 @@ implicit ack before callback is executed is necessary. | |||
|
|
|||
| === Connector | |||
| Connector concept is a way for connecting <<Channel,channels>> to external sources. | |||
| To make xref:connector.adoc[creation and usage of connectors] | |||
| To make creation and usage of connectors | |||
| as easy and versatile as possible, Helidon SE Messaging uses same API for connectors | |||
| like xref:../../mp/reactivemessaging/introduction.adoc[MicroProfile Reactive Messaging] does. | |||
| This allows connectors to be usable in both flavors of Helidon with one limitation which is | |||
There was a problem hiding this comment.
to be used in both Heldion MP and SE, however it has to be able to work without CDI.
8 tasks
|
@danielkec Hi - I can make these updates in another PR and have you review them. Is that ok? I don't want to conflict with your changes if you've already started? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4215
Signed-off-by: Daniel Kec daniel.kec@oracle.com