-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Microprofile Server Documentation #4545
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs refactoring based on latest @tomas-langer changes in the generation tool such as moving generated docs to /config
, using underscores instead of dots in file names, etc.
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, few edits.
re: title case comments - there is no action at this time. I will follow up with the team.
|
||
|
||
|
||
== Configuration options |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check case H2 title case
|
||
Helidon MP also supports custom TLS configuration. | ||
|
||
User is able to set following properties: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can set the following properties:
- Other ports (in this example we configure one "admin" port) can be assigned endpoints that are exposed by Helidon components, | ||
currently supported by MP Health and MP Metrics | ||
|
||
For this example, we will use a `yaml` file: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YAML file
routing: "admin" | ||
---- | ||
|
||
=== Configuring a reactive route |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
title case
You can assign a reactive service to a named routing (and as a result to a named port) using | ||
either an annotation or configuration (or both to override the value from annotation). | ||
|
||
====== Annotation `@RoutingName` [[annotation-routing-name]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
H6 - is there another way to format this section so that we don't have H6s? We typically stop at H4 but I understand that there are build issues that require a single file now.
See #4320
Signed-off-by: tvallin thibault.vallin@oracle.com