-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.x - Dbclient Integration Tests Fixed #4860
Conversation
|
e35b5a3
to
78bb094
Compare
@romain-grecourt Those tests are quite unstable. This changeset can't affect anything and they are still failing. |
@romain-grecourt I added one more changeset to run Db Client tests with H2 DB during regular -Ptests profile run. |
1f071f1
to
68459bc
Compare
7190cc4
to
4a6b7f6
Compare
@romain-grecourt I had to rewrite tests initialization for appl tests here. It was not working properly with in memory DBs. |
Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
c77b818
to
82f7bc5
Compare
...t/appl/src/test/java/io/helidon/tests/integration/dbclient/appl/it/health/HealthCheckIT.java
Outdated
Show resolved
Hide resolved
...lient/appl/src/test/java/io/helidon/tests/integration/dbclient/appl/it/mapping/MapperIT.java
Outdated
Show resolved
Hide resolved
...lient/appl/src/test/java/io/helidon/tests/integration/dbclient/appl/it/mapping/MapperIT.java
Outdated
Show resolved
Hide resolved
tests/integration/dbclient/appl/src/test/resources/logging.properties
Outdated
Show resolved
Hide resolved
Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
Code should look much better now. I went trough everything to fix bad coding style. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Some changes in
HealthCheck
API caused build issues with integration tests. Also name removal fromHealthCheckResponse
caused test failures.Fixed build issues mostly with import changes.
HealthCheck
name was checked as part of response. Changed this to verify name directly fromHealthCheck
instance.