Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x - Dbclient Integration Tests Fixed #4860

Merged
merged 8 commits into from
Jan 12, 2023

Conversation

Tomas-Kraus
Copy link
Member

@Tomas-Kraus Tomas-Kraus commented Sep 9, 2022

Some changes in HealthCheck API caused build issues with integration tests. Also name removal from HealthCheckResponse caused test failures.

Fixed build issues mostly with import changes.
HealthCheck name was checked as part of response. Changed this to verify name directly from HealthCheck instance.

@Tomas-Kraus Tomas-Kraus added bug Something isn't working health DB client Helidon DB Client testing integration 4.x Version 4.x labels Sep 9, 2022
@Tomas-Kraus Tomas-Kraus self-assigned this Sep 9, 2022
@Tomas-Kraus
Copy link
Member Author

Tomas-Kraus commented Sep 9, 2022

[INFO] Results:
[INFO] 
[INFO] Tests run: 141, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] 
[INFO] --- maven-failsafe-plugin:3.0.0-M5:integration-test (destroy) @ helidon-tests-integration-dbclient-jdbc ---
[INFO] Integration Tests: DB Client Common ................ SUCCESS [  1.930 s]
[INFO] Integration Tests: DB Client JDBC .................. SUCCESS [ 14.109 s]
[INFO] Results:
[INFO] 
[INFO] Tests run: 158, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] --- maven-failsafe-plugin:3.0.0-M5:verify (test) @ helidon-tests-integration-dbclient-appl ---
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------

@Tomas-Kraus
Copy link
Member Author

@romain-grecourt Those tests are quite unstable. This changeset can't affect anything and they are still failing.

@Tomas-Kraus
Copy link
Member Author

@romain-grecourt I added one more changeset to run Db Client tests with H2 DB during regular -Ptests profile run.
This should avoid at least build and some simple use-case regressions in tests.

@Tomas-Kraus Tomas-Kraus force-pushed the dbclient-it_fix branch 3 times, most recently from 1f071f1 to 68459bc Compare October 7, 2022 14:46
@barchetta barchetta changed the title Dbclient Integration Tests Fixed 4.x - Dbclient Integration Tests Fixed Oct 19, 2022
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 19, 2022
@Tomas-Kraus
Copy link
Member Author

Tomas-Kraus commented Dec 30, 2022

@romain-grecourt I had to rewrite tests initialization for appl tests here. It was not working properly with in memory DBs.
Also updated imports to match format pattern from Tomas L. and changed logger to use System.

Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
@Tomas-Kraus
Copy link
Member Author

Tomas-Kraus commented Jan 11, 2023

Code should look much better now. I went trough everything to fix bad coding style.

Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tomas-Kraus Tomas-Kraus merged commit 1dfee15 into helidon-io:main Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x bug Something isn't working DB client Helidon DB Client health integration OCA Verified All contributors have signed the Oracle Contributor Agreement. testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants