Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Move fetch of metrics from endpoint so it too is retried #5143

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

tjquinno
Copy link
Member

Resolves #4976

The earlier (incomplete) fix added a retry but left the fetch of the metrics from the /metrics endpoint outside the retry, so the same value would be used during retries (which would never have different results).

This PR moves the fetch of the metrics output so it is performed each time through the retry loop.

Signed-off-by: tim.quinn@oracle.com tim.quinn@oracle.com

Signed-off-by: tim.quinn@oracle.com <tim.quinn@oracle.com>
@tjquinno tjquinno merged commit 14eb43d into helidon-io:main Oct 10, 2022
@tjquinno tjquinno deleted the fix-asyncwithrest-main branch October 10, 2022 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants