-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support customize encoder and media context in Nima WebServer (#5256) #5257
Conversation
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA). To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
@romain-grecourt |
@tomas-langer Hi~, please take a look. Thanks |
...er/webserver/src/test/java/io/helidon/nima/webserver/builder/ContentEncodingContextTest.java
Outdated
Show resolved
Hide resolved
...er/webserver/src/test/java/io/helidon/nima/webserver/builder/ContentEncodingContextTest.java
Outdated
Show resolved
Hide resolved
...er/webserver/src/test/java/io/helidon/nima/webserver/builder/ContentEncodingContextTest.java
Outdated
Show resolved
Hide resolved
...er/webserver/src/test/java/io/helidon/nima/webserver/builder/ContentEncodingContextTest.java
Outdated
Show resolved
Hide resolved
...er/webserver/src/test/java/io/helidon/nima/webserver/builder/ContentEncodingContextTest.java
Outdated
Show resolved
Hide resolved
nima/webserver/webserver/src/test/java/io/helidon/nima/webserver/builder/MediaContextTest.java
Outdated
Show resolved
Hide resolved
15462d2
to
18f7797
Compare
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA). To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the contribution!
Hi, there seems to be some inconsistency in the users you used to create the commit and the PR. It seems our OCA checker is failing on this. If you could fix this please, we could continue with pipeline builds... |
83d1470
to
2ad80ce
Compare
Now my oca check seems ok, and now added missing copyright for my two tests. |
1dab831
to
aeee4f0
Compare
aeee4f0
to
d3c62e4
Compare
Please take a look, Thanks.