Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Guava version to match that required by the grpc-java libraries #5446

Merged
merged 4 commits into from
Nov 21, 2022
Merged

Fix Guava version to match that required by the grpc-java libraries #5446

merged 4 commits into from
Nov 21, 2022

Conversation

thegridman
Copy link
Collaborator

The version of Guava used in the grpc/io.grpc module must match the version required by the gRPC Java libraries. Ideally we would just pull in the correct version as a transitive dependency, but due to how the shading and repackaging is done, the module-info.java file will not compile without Guava as a dependency in the pom.xml.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Nov 16, 2022
@barchetta barchetta added the 2.x Issues for 2.x version branch label Nov 17, 2022
@barchetta barchetta added this to the 2.5.5 milestone Nov 17, 2022
@barchetta barchetta merged commit 655b5c3 into helidon-io:helidon-2.x Nov 21, 2022
@thegridman thegridman deleted the grpc-dependencies branch November 22, 2022 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Issues for 2.x version branch OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants