Quickstart update for native images #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OSSRH does not have a hosted release repo available, thus a profile for ossrh-release does not make sense. Move the nexus-staging-maven-plugin declaration with extension=true in the release profile.
…d-tools, bump the value from 1.0.9 to 1.0.10
tomas-langer
reviewed
Apr 4, 2019
examples/quickstarts/helidon-quickstart-se/src/main/docker/Dockerfile.native
Outdated
Show resolved
Hide resolved
examples/quickstarts/helidon-quickstart-se/src/main/docker/Dockerfile.native
Outdated
Show resolved
Hide resolved
tomas-langer
reviewed
Apr 4, 2019
This comment has been minimized.
This comment has been minimized.
- Use a shell script instead of archetype:create-from-project - Make all Dockerfiles multi-stage docker builds using Maven. - Move Dockerfiles and app.yaml at the top level.
Update the docker image guide. Use uniqueVersions=false in the manifest jar config.
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
romain-grecourt
dismissed
tomas-langer’s stale review
Feedback has been incorporated, merging now to accomodate timezone difference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the helidon-quickstart-se example "GraalVM ready" instead of having a separate example.
Use a custom Maven plugin to execute the
native-imagecommand.