Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.x] OpenApi Generator examples #5722

Merged
merged 14 commits into from
Feb 24, 2023
Merged

[2.x] OpenApi Generator examples #5722

merged 14 commits into from
Feb 24, 2023

Conversation

aserkes
Copy link
Contributor

@aserkes aserkes commented Dec 19, 2022 •
edited
Loading

Fixes #5669
[2.x] backport for OpenApi Generator examples

@aserkes
remove -Ddocker.build=true
a5a0c4c 
Signed-off-by: aserkes <andrii.serkes@oracle.com>
@aserkes
fix copyrights
f22173b 
Signed-off-by: aserkes <andrii.serkes@oracle.com>
@aserkes
Merge remote-tracking branch 'upstream/helidon-2.x' into helidon-2.x-…
6ebe36f 
…upstream
@aserkes
Merge remote-tracking branch 'upstream/helidon-2.x' into helidon-2.x-…
a52902f 
…upstream
@aserkes
[2.x] backport for OpenApi Generator examples
0ecc9a0 
Signed-off-by: aserkes <andrii.serkes@oracle.com>
@aserkes aserkes self-assigned this Dec 19, 2022
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Dec 19, 2022
@aserkes aserkes marked this pull request as draft December 19, 2022 17:23
@aserkes
fix copyright
bc135fe 
Signed-off-by: aserkes <andrii.serkes@oracle.com>
@aserkes aserkes marked this pull request as ready for review December 20, 2022 10:01
@aserkes
fix checkstyle
38983c7 
Signed-off-by: aserkes <andrii.serkes@oracle.com>
@aserkes aserkes requested a review from tjquinno December 20, 2022 15:19
tjquinno
tjquinno requested changes Feb 22, 2023
View reviewed changes
Copy link
Member

@tjquinno tjquinno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should change the Helidon version as noted (because I'm so late reviewing this).

examples/openapi-tools/quickstart-mp/README.md Outdated Show resolved Hide resolved
examples/openapi-tools/quickstart-mp/README.md Outdated Show resolved Hide resolved
examples/openapi-tools/quickstart-mp/mp-client/pom.xml Outdated Show resolved Hide resolved
examples/openapi-tools/quickstart-mp/mp-server/pom.xml Outdated Show resolved Hide resolved
examples/openapi-tools/quickstart-se/se-client/pom.xml Outdated Show resolved Hide resolved
examples/openapi-tools/quickstart-se/se-server/pom.xml Outdated Show resolved Hide resolved
@aserkes
update Helidon version
a991f0e 
Signed-off-by: aserkes <andrii.serkes@oracle.com>
@aserkes
Merge branch 'helidon-2.x-upstream' into 5669-2.x-openapi-generator-e…
9d9db9a 
…xamples
@aserkes
fix copyright
1184a8f 
Signed-off-by: aserkes <andrii.serkes@oracle.com>
@aserkes
fix Helidon version for parent pom
c945377 
Signed-off-by: aserkes <andrii.serkes@oracle.com>
@aserkes
fix Helidon version for parent pom
96245e9 
Signed-off-by: aserkes <andrii.serkes@oracle.com>
@aserkes
fix copyright
6455ec7 
Signed-off-by: aserkes <andrii.serkes@oracle.com>
@aserkes
fix copyright
03c62ae 
Signed-off-by: aserkes <andrii.serkes@oracle.com>
@aserkes aserkes requested a review from tjquinno February 23, 2023 15:07
@aserkes aserkes merged commit 2575668 into helidon-io:helidon-2.x Feb 24, 2023
@aserkes aserkes linked an issue Feb 24, 2023 that may be closed by this pull request
[2.x] Backport of #4269 OpenAPI generator examples #5669
Closed
@aserkes aserkes deleted the 5669-2.x-openapi-generator-examples branch February 24, 2023 08:43
@Captain1653
Copy link
Contributor

I can be wrong, but there are many wrong copyrights in this PR.
Screenshot 2023-02-24 at 22 24 38

@romain-grecourt
Copy link
Contributor

@Captain1653 This is the PR was created in 2022 and merged in 2023.

@romain-grecourt romain-grecourt mentioned this pull request Feb 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjquinno tjquinno tjquinno approved these changes

Assignees

@aserkes aserkes

Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[2.x] Backport of #4269 OpenAPI generator examples
4 participants
@aserkes @Captain1653 @romain-grecourt @tjquinno